Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix verify execution result #6804

Merged
merged 4 commits into from
Dec 13, 2024
Merged

Conversation

zhangchiqing
Copy link
Member

@zhangchiqing zhangchiqing commented Dec 12, 2024

This PR:

  • Skip unexecuted sealed block when verifying execution result with the util commands. This is to solve the problem that when automation is trying to verify the last X sealed blocks, it fails because the last sealed block is not executed.
  • Raise error if the chunk data pack db is not initialized, useful when specifying with a wrong chunk data pack dir
  • Log the specified chunk data pack dir

@zhangchiqing zhangchiqing force-pushed the leo/fix-verify-execution-result branch from 7f6af8b to 938143b Compare December 12, 2024 19:21
@zhangchiqing zhangchiqing marked this pull request as ready for review December 12, 2024 19:23
@codecov-commenter
Copy link

codecov-commenter commented Dec 12, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 33 lines in your changes missing coverage. Please review.

Project coverage is 40.96%. Comparing base (541d744) to head (938143b).

Files with missing lines Patch % Lines
storage/pebble/open.go 59.45% 10 Missing and 5 partials ⚠️
cmd/util/cmd/verify_execution_result/cmd.go 0.00% 13 Missing ⚠️
engine/verification/verifier/verifiers.go 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6804      +/-   ##
==========================================
+ Coverage   40.95%   40.96%   +0.01%     
==========================================
  Files        2093     2093              
  Lines      184432   184478      +46     
==========================================
+ Hits        75528    75570      +42     
- Misses     102582   102583       +1     
- Partials     6322     6325       +3     
Flag Coverage Δ
unittests 40.96% <40.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhangchiqing zhangchiqing added this pull request to the merge queue Dec 13, 2024
Merged via the queue into master with commit 61a0b0e Dec 13, 2024
55 checks passed
@zhangchiqing zhangchiqing deleted the leo/fix-verify-execution-result branch December 13, 2024 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants