Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport 0.37 fix verify execution result #6805

Merged
merged 4 commits into from
Dec 16, 2024

Conversation

zhangchiqing
Copy link
Member

Backport #6804 to v0.37

@zhangchiqing zhangchiqing marked this pull request as ready for review December 12, 2024 19:32
@codecov-commenter
Copy link

codecov-commenter commented Dec 12, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 33 lines in your changes missing coverage. Please review.

Project coverage is 41.50%. Comparing base (eaa65ca) to head (c70508e).

Files with missing lines Patch % Lines
storage/pebble/open.go 59.45% 10 Missing and 5 partials ⚠️
cmd/util/cmd/verify_execution_result/cmd.go 0.00% 13 Missing ⚠️
engine/verification/verifier/verifiers.go 0.00% 5 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            v0.37    #6805   +/-   ##
=======================================
  Coverage   41.49%   41.50%           
=======================================
  Files        2032     2032           
  Lines      181405   181451   +46     
=======================================
+ Hits        75281    75315   +34     
- Misses      99895    99902    +7     
- Partials     6229     6234    +5     
Flag Coverage Δ
unittests 41.50% <40.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhangchiqing zhangchiqing merged commit 0507f92 into v0.37 Dec 16, 2024
55 checks passed
@zhangchiqing zhangchiqing deleted the leo/v0.37-fix-verify-execution-result branch December 16, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants