Create GraphQL-REST Controller for Branches and Tags #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #190 +/- ##
==========================================
+ Coverage 99.97% 99.97% +<.01%
==========================================
Files 197 201 +4
Lines 4599 4701 +102
==========================================
+ Hits 4598 4700 +102
Misses 1 1
Continue to review full report at Codecov.
|
eugenk
requested changes
Aug 25, 2017
| # frozen_string_literal: true | ||
|
|
||
| module V3 | ||
| # Handles requests for branches read operations |
| # frozen_string_literal: true | ||
|
|
||
| module V3 | ||
| # Handles requests for tags read operations |
| 'name' => params[:name]} | ||
| end | ||
| query <<-QUERY | ||
| query ($id: ID!,$name: String!) { |
There was a problem hiding this comment.
Please add a space after the comma
| 'name' => params[:name]} | ||
| end | ||
| query <<-QUERY | ||
| query ($id: ID!,$name: String!) { |
There was a problem hiding this comment.
Please add a space after the comma
config/routes.rb
Outdated
| get '/tags', | ||
| controller: 'v3/tags', action: 'index' | ||
| get '/tags/:name', | ||
| controller: 'v3/tags', action: 'show' |
There was a problem hiding this comment.
Please make all of these one-lined if they fit in 80 characters.
| "id": { | ||
| "type": "string", | ||
| "example": "498875f01d2f57f01a83338d80f0fd0b05b39eb4", | ||
| "description": "ID of the tag" |
There was a problem hiding this comment.
The ID of the commit that the tag points to
| "id":{ | ||
| "type": "string", | ||
| "example": "498875f01d2f57f01a83338d80f0fd0b05b39eb4", | ||
| "description": "ID of the branch" |
There was a problem hiding this comment.
The ID of the commit that the branch points to
| "type": "string", | ||
| "example": "my first annotated tag", | ||
| "description": "Annotation of the tag" | ||
| } |
There was a problem hiding this comment.
The annotation can be null. Please use oneOf.
| }, | ||
| { | ||
| "title": "Index", | ||
| "description": "List all tags of an repository Returns HTTP 200 (OK).", |
| "targetSchema": { "$ref": "#/definitions/actions/index" } | ||
| } | ||
| ] | ||
| } |
|
Since #198 is merged, you need to
|
DerProfessor
force-pushed
the
184-create_graphql-rest_controller_for_branches_and_tags
branch
from
946ce4e to
f049788
Compare
eugenk
requested changes
Sep 6, 2017
| # frozen_string_literal: true | ||
|
|
||
| module Rest | ||
| # Handles requests for tags read operations |
DerProfessor
deleted the
184-create_graphql-rest_controller_for_branches_and_tags
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #184