197 Move all V3 Controllers into a Rest Namespace #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think there's something wrong with Travis. Not sure what it is. |
eugenk
force-pushed
the
197-move_all_v3_controllers_into_a_rest_namespace
branch
from
869b7ed to
03afb47
Compare
phyrog
reviewed
Sep 1, 2017
| # We exclude the devise routes from these rake tasks because they load the | ||
| # models. When loading the models, the database needs to exist, or else it | ||
| # throws an error. | ||
| unless rake_task?(%w(db:create db:migrate db:drop |
There was a problem hiding this comment.
I think this is still needed, might also be the problem Travis has, see #69.
phyrog
reviewed
Sep 1, 2017
config/routes.rb
Outdated
| # We exclude these Devise mappings from these rake tasks because they | ||
| # load the models. When loading the models, the database needs to exist, | ||
| # or else it throws an error. | ||
| unless rake_task?(%w(db:create db:migrate db:drop)) |
There was a problem hiding this comment.
Might be necessary to add db:recreate and db:recreate:seed as well (you forgot to copy a line 😄)
eugenk
force-pushed
the
197-move_all_v3_controllers_into_a_rest_namespace
branch
from
cb59436 to
d65e1fe
Compare
eugenk
force-pushed
the
197-move_all_v3_controllers_into_a_rest_namespace
branch
from
d65e1fe to
d447d10
Compare
phyrog
requested changes
Sep 1, 2017
There was a problem hiding this comment.
Some v3s in the code left:
spec/support/api/schemas/rest/organizational_units_controller.json
125: "href": "/v3/{#/definitions/id}",
spec/support/api/schemas/rest/version_controller.json
57: "href": "/v3/version",
spec/support/api/schemas/rest/repositories_controller.json
127: "href": "/v3/{#/definitions/id}",
136: "href": "/v3/{#/definitions/organizational_unit_id}",
Codecov Report
@@ Coverage Diff @@
## master #198 +/- ##
==========================================
- Coverage 99.97% 99.97% -0.01%
==========================================
Files 196 197 +1
Lines 4621 4599 -22
==========================================
- Hits 4620 4598 -22
Misses 1 1
Continue to review full report at Codecov.
|
phyrog
reviewed
Sep 1, 2017
| # This is the base class for all API Version 3 Controllers. | ||
| class ApplicationController < ActionController::API | ||
| extend DSL | ||
|
|
||
| context do | ||
| {current_user: current_user} | ||
| end | ||
|
|
||
| def no_op |
|
Well, that took some doing... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This shall fix #197 along with some cleanup (see the commit messages).