fix(featctl/cmd): pass in revision-id

oom-ai · Nov 12, 2021 · 464b83d · 464b83d
1 parent fc58b8d
commit 464b83d
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 6 deletions.
diff --git a/featctl/cmd/get_historical_feature.go b/featctl/cmd/get_historical_feature.go
@@ -19,9 +19,6 @@ var getHistoricalFeatureCmd = &cobra.Command{
 	Use:   "historical-feature",
 	Short: "get historical features in a group",
 	PreRun: func(cmd *cobra.Command, args []string) {
-		if !cmd.Flags().Changed("revision") {
-			getHistoricalFeatureOpt.Revision = nil
-		}
 		if !cmd.Flags().Changed("limit") {
 			getHistoricalFeatureOpt.Limit = nil
 		}
@@ -53,6 +50,8 @@ func init() {
 	flags.StringVarP(&getHistoricalFeatureOpt.groupName, "group", "g", "", "feature group name")
 	_ = getHistoricalFeatureCmd.MarkFlagRequired("group")
 
+	flags.Int32VarP(&getHistoricalFeatureOpt.RevisionID, "revision-id", "r", 0, "group revision id")
+	_ = getHistoricalFeatureCmd.MarkFlagRequired("revision-id")
+
 	getHistoricalFeatureOpt.Limit = flags.Uint64P("limit", "l", 0, "max records to export")
-	getHistoricalFeatureOpt.Revision = flags.Int64P("revision", "r", 0, "feature group revision")
 }
diff --git a/featctl/cmd/sync.go b/featctl/cmd/sync.go
@@ -32,6 +32,6 @@ func init() {
 
 	flags := syncCmd.Flags()
 
-	flags.Int32VarP(&syncOpt.RevisionId, "revision", "r", 0, "group revision id")
-	_ = syncCmd.MarkFlagRequired("revision")
+	flags.Int32VarP(&syncOpt.RevisionId, "revision-id", "r", 0, "group revision id")
+	_ = syncCmd.MarkFlagRequired("revision-id")
 }