Cherry pick linking time fix to Humble #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Improve linking times (#61) Signed-off-by: Luca Della Vedova <[email protected]> Signed-off-by: Michael X. Grey <[email protected]> Co-authored-by: Luca Della Vedova <[email protected]> * Make CI run with Iron images Signed-off-by: Yadunund <[email protected]> --------- Signed-off-by: Luca Della Vedova <[email protected]> Signed-off-by: Michael X. Grey <[email protected]> Signed-off-by: Yadunund <[email protected]> Co-authored-by: Grey <[email protected]> Co-authored-by: Luca Della Vedova <[email protected]> Signed-off-by: Luca Della Vedova <[email protected]>
Signed-off-by: Luca Della Vedova <[email protected]>
luca-della-vedova
changed the title
Signed-off-by: Luca Della Vedova <[email protected]>
|
It looks like we'll need to merge open-rmf/rmf_ros2#356 before this is able to work. CMake is complaining about targets missing, so I guess our old cmake wasn't exporting upstream targets correctly..? |
|
Yap, now that it's merged CI is green |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to (and depends on) open-rmf/rmf_ros2#356, reduce linking time in Humble, the only additional change is that the cherry picked PR also updated CI to run on Iron, I undoed these changes in a separate commit 34a7273