Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move messages in StatusReport to AgentToServer message #84

Closed
tigrannajaryan opened this issue May 20, 2022 · 2 comments · Fixed by #85
Closed

Move messages in StatusReport to AgentToServer message #84

tigrannajaryan opened this issue May 20, 2022 · 2 comments · Fixed by #85

Comments

@tigrannajaryan
Copy link
Member

It is not clear why we have StatusReport, which contains 4 fields, instead of putting the fields directly in AgentToServer.

Can we move the fields to AgentToServer and eliminate StatusReport message?
@tigrannajaryan
Copy link
Member Author

Here is what the change can look like: open-telemetry/opamp-go#83

@andykellr @pmm-sumo what do you think?

@andykellr
Copy link
Contributor

I like this change.

tigrannajaryan added a commit to tigrannajaryan/opamp-spec that referenced this issue May 25, 2022
@tigrannajaryan
Move messages in StatusReport to AgentToServer message
2c8930d 
StatusReport was an unnecessary message. All its fields are moved to
AgentToServer message now.

Resolves open-telemetry#84
tigrannajaryan added a commit to tigrannajaryan/opamp-spec that referenced this issue May 25, 2022
@tigrannajaryan
Move messages in StatusReport to AgentToServer message
15ae992 
- StatusReport was an unnecessary message, remaining from the time
  when we had DataToAgent which had a oneof field and it was
  impossible to set mulitiple fields that together form the status.
  All its fields are moved to AgentToServer message now and can be
  set directly there (there is no longer a oneof limitation so now
  this is possible to do).
- Moved Agent to Server State Synchronization under Status Reporting
  where it is more relevant and renamed to Agent Status Compression.

Resolves open-telemetry#84
tigrannajaryan added a commit to tigrannajaryan/opamp-spec that referenced this issue May 25, 2022
@tigrannajaryan
Move messages in StatusReport to AgentToServer message
1172a02 
- StatusReport was an unnecessary message, remaining from the time
  when we had DataToAgent which had a oneof field and it was
  impossible to set mulitiple fields that together form the status.
  All its fields are moved to AgentToServer message now and can be
  set directly there (there is no longer a oneof limitation so now
  this is possible to do).
- Moved Agent to Server State Synchronization under Status Reporting
  where it is more relevant and renamed to Agent Status Compression.

Resolves open-telemetry#84
tigrannajaryan added a commit to tigrannajaryan/opamp-spec that referenced this issue May 25, 2022
@tigrannajaryan
Move messages in StatusReport to AgentToServer message
5078a1b 
- StatusReport was an unnecessary message, remaining from the time
  when we had DataToAgent which had a oneof field, and it was
  impossible to set multiple fields that together form the status.
  All its fields are moved to AgentToServer message now and can be
  set directly there (there is no longer a oneof limitation so now
  this is possible to do).
- Moved Agent to Server State Synchronization under Status Reporting
  where it is more relevant and renamed to Agent Status Compression.

Resolves open-telemetry#84
@tigrannajaryan tigrannajaryan mentioned this issue May 25, 2022
Merged
tigrannajaryan added a commit to tigrannajaryan/opamp-spec that referenced this issue May 25, 2022
@tigrannajaryan
Move messages in StatusReport to AgentToServer message
4ff0244 
- StatusReport was an unnecessary message, remaining from the time
  when we had DataToAgent which had a oneof field, and it was
  impossible to set multiple fields that together form the status.
  All its fields are moved to AgentToServer message now and can be
  set directly there (there is no longer a oneof limitation so now
  this is possible to do).
- Moved Agent to Server State Synchronization under Status Reporting
  where it is more relevant and renamed to Agent Status Compression.

Resolves open-telemetry#84
tigrannajaryan added a commit to tigrannajaryan/opamp-spec that referenced this issue May 25, 2022
@tigrannajaryan
Move messages in StatusReport to AgentToServer message
7303ea8 
- StatusReport was an unnecessary message, remaining from the time
  when we had DataToAgent which had a oneof field, and it was
  impossible to set multiple fields that together form the status.
  All its fields are moved to AgentToServer message now and can be
  set directly there (there is no longer a oneof limitation so now
  this is possible to do).
- Moved Agent to Server State Synchronization under Status Reporting
  where it is more relevant and renamed to Agent Status Compression.

Resolves open-telemetry#84
tigrannajaryan added a commit that referenced this issue May 26, 2022
@tigrannajaryan
Move messages in StatusReport to AgentToServer message (#85)
bc9c8ba 
- StatusReport was an unnecessary message, remaining from the time
  when we had DataToAgent which had a oneof field, and it was
  impossible to set multiple fields that together form the status.
  All its fields are moved to AgentToServer message now and can be
  set directly there (there is no longer a oneof limitation so now
  this is possible to do).
- Moved Agent to Server State Synchronization under Status Reporting
  where it is more relevant and renamed to Agent Status Compression.

Resolves #84
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move messages in StatusReport to AgentToServer message tigrannajaryan/opamp-spec
2 participants
@andykellr @tigrannajaryan