Move messages in StatusReport to AgentToServer message #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tigrannajaryan
force-pushed
the
feature/tigran/eliminate-status-report
branch
from
5078a1b to
4ff0244
Compare
tigrannajaryan
added a commit
to tigrannajaryan/opamp-go
that referenced
this pull request
May 25, 2022
StatusReport was an unnecessary message, remaining from the time when we had DataToAgent which had a oneof field, and it was impossible to set multiple fields that together form the status. All its fields are moved to AgentToServer message now and can be set directly there (there is no longer a oneof limitation so now this is possible to do). Implements spec change: open-telemetry/opamp-spec#85
tigrannajaryan
added a commit
to tigrannajaryan/opamp-go
that referenced
this pull request
May 25, 2022
StatusReport was an unnecessary message, remaining from the time when we had DataToAgent which had a oneof field, and it was impossible to set multiple fields that together form the status. All its fields are moved to AgentToServer message now and can be set directly there (there is no longer a oneof limitation so now this is possible to do). Implements spec change: open-telemetry/opamp-spec#85
tigrannajaryan
added a commit
to open-telemetry/opamp-go
that referenced
this pull request
May 25, 2022
StatusReport was an unnecessary message, remaining from the time when we had DataToAgent which had a oneof field, and it was impossible to set multiple fields that together form the status. All its fields are moved to AgentToServer message now and can be set directly there (there is no longer a oneof limitation so now this is possible to do). Implements spec change: open-telemetry/opamp-spec#85
- StatusReport was an unnecessary message, remaining from the time when we had DataToAgent which had a oneof field, and it was impossible to set multiple fields that together form the status. All its fields are moved to AgentToServer message now and can be set directly there (there is no longer a oneof limitation so now this is possible to do). - Moved Agent to Server State Synchronization under Status Reporting where it is more relevant and renamed to Agent Status Compression. Resolves open-telemetry#84
tigrannajaryan
force-pushed
the
feature/tigran/eliminate-status-report
branch
from
4ff0244 to
7303ea8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when we had DataToAgent which had a oneof field, and it was
impossible to set multiple fields that together form the status.
All its fields are moved to AgentToServer message now and can be
set directly there (there is no longer a oneof limitation so now
this is possible to do).
where it is more relevant and renamed to Agent Status Compression.
Resolves #84