Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[receiver/elasticsearch]: add segment metrics with total aggregation #14786

Merged
merged 2 commits into from
Oct 31, 2022
Merged

[receiver/elasticsearch]: add segment metrics with total aggregation #14786

merged 2 commits into from
Oct 31, 2022

Conversation

aboguszewski-sumo
Copy link
Member

@aboguszewski-sumo aboguszewski-sumo commented Oct 10, 2022 •
edited
Loading

Description:
This PR adds new metrics to the receiver:

elasticsearch_indices_stats_total_segments_count
elasticsearch_indices_stats_total_segments_doc_values_memory_in_bytes
elasticsearch_indices_stats_total_segments_fixed_bit_set_memory_in_bytes
elasticsearch_indices_stats_total_segments_index_writer_memory_in_bytes
elasticsearch_indices_stats_total_segments_memory_in_bytes
elasticsearch_indices_stats_total_segments_terms_memory_in_bytes

Link to tracking Issue: #14635

Testing:
Unit and integration tests.

Documentation:
Generated with mdatagen.

@aboguszewski-sumo aboguszewski-sumo requested a review from a team October 10, 2022 07:25
@aboguszewski-sumo aboguszewski-sumo mentioned this pull request Oct 10, 2022
Merged
@aboguszewski-sumo
Copy link
Member Author

aboguszewski-sumo commented Oct 11, 2022 •
edited
Loading

@djaglowski I have added several pull requests today, but this one is the most important, because merging this will allow me to add more segments metrics. If you aren't able to review all the pull requests, please focus on this one.

This was referenced Oct 11, 2022
Merged
Closed
@djaglowski
Copy link
Member

Please fix unit tests.

@aboguszewski-sumo
Copy link
Member Author

Unit and integration tests fixed.

@djaglowski
Copy link
Member

@aboguszewski-sumo, please rebase.

@aboguszewski-sumo
Copy link
Member Author

@djaglowski rebased, the failures in CI are from some unrelated component

djaglowski
djaglowski reviewed Oct 28, 2022
View reviewed changes
receiver/elasticsearchreceiver/metadata.yaml Outdated
aggregation: cumulative
value_type: int
attributes: [index_aggregation_type]
enabled: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to have these disabled by default going forward, otherwise it is a breaking change and requires use of a feature gate.

@aboguszewski-sumo
Copy link
Member Author

The metrics are now disabled by default.

@djaglowski
Copy link
Member

/easycla

@djaglowski djaglowski merged commit 30e388b into open-telemetry:main Oct 31, 2022
This was referenced Nov 3, 2022
Merged
Merged
shalper2 pushed a commit to shalper2/opentelemetry-collector-contrib that referenced this pull request Dec 6, 2022
@aboguszewski-sumo @shalper2
[receiver/elasticsearch]: add segment metrics with total aggregation (o…
4bf2476 
…pen-telemetry#14786)

* feat: add segment metrics with total aggregation
@plantfansam plantfansam mentioned this pull request Jul 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djaglowski djaglowski djaglowski approved these changes

Assignees

@Aneurysm9 Aneurysm9

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aboguszewski-sumo @djaglowski @Aneurysm9