[receiver/elasticsearch]: add cluster health metrics for two more shard types #14875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
djaglowski
reviewed
Nov 1, 2022
There was a problem hiding this comment.
LGTM, but we should use a feature gate. https://github.com/open-telemetry/opentelemetry-collector/pull/6358/files defines reasonable process for this even if not yet merged.
aboguszewski-sumo
force-pushed
the
elastic-add-cluster-health-shards
branch
from
699dce8 to
f923358
Compare
|
I added the feature gate. Please confirm if the expected version for the next step of feature gate in the readme is correct (according to the docs you sent, if this gets released in |
aboguszewski-sumo
force-pushed
the
elastic-add-cluster-health-shards
branch
from
f923358 to
40eb901
Compare
aboguszewski-sumo
force-pushed
the
elastic-add-cluster-health-shards
branch
from
40eb901 to
819030d
Compare
aboguszewski-sumo
force-pushed
the
elastic-add-cluster-health-shards
branch
from
0bea4f7 to
b053ced
Compare
djaglowski
approved these changes
Nov 15, 2022
aboguszewski-sumo
requested review from
djaglowski
and removed request for
BinaryFissionGames
|
@djaglowski workflow failed, could you rerun and merge? |
JaredTan95
pushed a commit
to openinsight-proj/opentelemetry-collector-contrib
that referenced
this pull request
Nov 21, 2022
…rd types (open-telemetry#14875) * feat: add cluster health metrics for two more shard types
shalper2
pushed a commit
to shalper2/opentelemetry-collector-contrib
that referenced
this pull request
Dec 6, 2022
…rd types (open-telemetry#14875) * feat: add cluster health metrics for two more shard types
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Two more metrics have been added:
I had problem adding these two metrics, because basically any good solution would be a breaking change. I decided to pick the solution that doesn't break anything: I added new
shard_stateenum values. However, according to this:#14786 (comment)
this solution is not very good, because
active_primary_shardsis subset ofactive_shardsand same withdelayed_unassigned_shardsandunassigned_shards.Note: adding additional attribute such as
is_primarywon't help much, because this is the only field regarding to primary shards, same with delayed.Link to tracking Issue: #14635
Testing:
Tests will be added when the metric schema gets accepted.
Documentation:
mdatagen