Fix license header, typos and lints. #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
songy23
requested review from
bogdandrutu,
flands,
pjanotti and
tigrannajaryan
as code owners
Codecov Report
@@ Coverage Diff @@
## master #160 +/- ##
=========================================
Coverage ? 71.74%
=========================================
Files ? 103
Lines ? 6014
Branches ? 0
=========================================
Hits ? 4315
Misses ? 1476
Partials ? 223
Continue to review full report at Codecov.
|
I'm not sure if there's a similar tool in open source. I'll take a look at the CI config of other Go github repos. |
tigrannajaryan
approved these changes
Jul 17, 2019
|
Thanks, commit messages fixed. |
MovieStoreGuy
pushed a commit
to atlassian-forks/opentelemetry-collector
that referenced
this pull request
Nov 11, 2021
* Add Stackdriver Trace exporter for trace. TODOs for future work is: * to replace bundler.Bundler * to add proper tests for the exporter * to move the exporter to proper repository once it will be created. * Change to use functions for the exporter initialization instead of passing option struct directly. This fix is aliging the same fix for Jaeger (open-telemetry#146, open-telemetry#161) * Change Option struct to be function type * Change the original Option struct to be private * Add line comments to maxMessageEventsPerSpan to leave it for future implementation * Fix unnessesary expressions specified by `make precommit` Left errors by `make precommit` in experimental/bridge/opentracing. * Ran make precommit * Add new line at EOF * WIP: Start implementing BatchSpanExporter interfaces * Change to use RegisterSpanProcessor to register bsp * Change function names to fit current implementation of sdk * Removed google.golang.org/api/support/bundler and implement ssp and bsp * Change spanProcessor as a member of Exporter. * Fix option names used for BatchSpanProcessor initialization. * Change Exporter.Shutdown just to unregister spanProcessor. * Removed copyright statements of OpenCensus. * Fix small typo and EOF new line * Fix interfaces of ExportSpan/ExportSpans to meet SpanSyncer/SpanBatcher * Change to follow context.Context passed in ExportSpan/ExportSpans * Fix Stackdriver Exporter to hold sync.Once to lock when it is registered and unregistered.
hughesjj
pushed a commit
to hughesjj/opentelemetry-collector
that referenced
this pull request
Apr 27, 2023
Troels51
pushed a commit
to Troels51/opentelemetry-collector
that referenced
this pull request
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.