Clean up stale code in receiver/vmmetrics #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
songy23
requested review from
bogdandrutu,
flands,
pjanotti and
tigrannajaryan
as code owners
Codecov Report
@@ Coverage Diff @@
## master #161 +/- ##
==========================================
+ Coverage 71.74% 74.08% +2.33%
==========================================
Files 103 95 -8
Lines 6014 5796 -218
==========================================
- Hits 4315 4294 -21
+ Misses 1476 1287 -189
+ Partials 223 215 -8
Continue to review full report at Codecov.
|
songy23
force-pushed
the
vmmetrics-receiver
branch
from
0ef4c82 to
5896f5b
Compare
There was a problem hiding this comment.
Generally LGTM, just a comment regarding commit message.
Please see https://github.com/open-telemetry/community/blob/master/CONTRIBUTING.md#code-review and https://chris.beams.io/posts/git-commit/
Rule 3: Capitalize the subject line
I suggest "Clean up stale code in receiver/vmmetrics"
Rule 4: Do not end the subject line with a period
Rule 7: Use the body to explain what and why vs. how
"Receiver will be loaded through config.go instead of viper." answers the the "how" question. The "what" question can be answered by e.g. the following:
Old viper code is removed because it is no longer needed with the new factory/config approach.
5896f5b to
c2ba932
Compare
|
Build failure seems to be due to processor: processor/attributekeyprocessor/factory.go:26:9: undefined: processor.RegisterFactory
# github.com/open-telemetry/opentelemetry-service/processor/attributekeyprocessor [github.com/open-telemetry/opentelemetry-service/processor/attributekeyprocessor.test]
processor/attributekeyprocessor/factory.go:26:9: undefined: processor.RegisterFactory
processor/attributekeyprocessor/config_test.go:29:9: undefined: config.RegisterTestFactories
processor/attributekeyprocessor/config_test.go:33:38: not enough arguments in call to config.LoadConfigFile
have (*testing.T, string)
want (*testing.T, string, map[string]receiver.Factory, map[string]processor.Factory, map[string]exporter.Factory)
processor/attributekeyprocessor/config_test.go:71:13: undefined: processor.GetFactory
processor/attributekeyprocessor/config_test.go:73:38: not enough arguments in call to config.LoadConfigFile
have (*testing.T, string)
want (*testing.T, string, map[string]receiver.Factory, map[string]processor.Factory, map[string]exporter.Factory)
processor/attributekeyprocessor/factory_test.go:30:13: undefined: processor.GetFactory
processor/attributekeyprocessor/factory_test.go:38:13: undefined: processor.GetFactory
make: *** [vet] Error 2@pjanotti can you take a look? |
songy23
force-pushed
the
vmmetrics-receiver
branch
from
c2ba932 to
fe6dc0a
Compare
|
@songy23 the build failure is on a code that I no longer see in |
|
Never mind #163 fixed it. Rebased. |
pjanotti
approved these changes
Jul 17, 2019
songy23
force-pushed
the
vmmetrics-receiver
branch
from
fe6dc0a to
41e8ae3
Compare
Old viper code is removed because it is no longer needed with the new factory/config approach. Receiver will be loaded through config.go instead of viper.
songy23
force-pushed
the
vmmetrics-receiver
branch
from
41e8ae3 to
0c9b822
Compare
|
Commit message fixed, PTAL @tigrannajaryan |
songy23
changed the title
MovieStoreGuy
pushed a commit
to atlassian-forks/opentelemetry-collector
that referenced
this pull request
Nov 11, 2021
* change jaeger options to functional style * fix lints * add interface validaiton
MovieStoreGuy
pushed a commit
to atlassian-forks/opentelemetry-collector
that referenced
this pull request
Nov 11, 2021
* Add Stackdriver Trace exporter for trace. TODOs for future work is: * to replace bundler.Bundler * to add proper tests for the exporter * to move the exporter to proper repository once it will be created. * Change to use functions for the exporter initialization instead of passing option struct directly. This fix is aliging the same fix for Jaeger (open-telemetry#146, open-telemetry#161) * Change Option struct to be function type * Change the original Option struct to be private * Add line comments to maxMessageEventsPerSpan to leave it for future implementation * Fix unnessesary expressions specified by `make precommit` Left errors by `make precommit` in experimental/bridge/opentracing. * Ran make precommit * Add new line at EOF * WIP: Start implementing BatchSpanExporter interfaces * Change to use RegisterSpanProcessor to register bsp * Change function names to fit current implementation of sdk * Removed google.golang.org/api/support/bundler and implement ssp and bsp * Change spanProcessor as a member of Exporter. * Fix option names used for BatchSpanProcessor initialization. * Change Exporter.Shutdown just to unregister spanProcessor. * Removed copyright statements of OpenCensus. * Fix small typo and EOF new line * Fix interfaces of ExportSpan/ExportSpans to meet SpanSyncer/SpanBatcher * Change to follow context.Context passed in ExportSpan/ExportSpans * Fix Stackdriver Exporter to hold sync.Once to lock when it is registered and unregistered.
hughesjj
pushed a commit
to hughesjj/opentelemetry-collector
that referenced
this pull request
Apr 27, 2023
* smartagent: support logs * smartagent: remove event clients in favor of log pipelines
Troels51
pushed a commit
to Troels51/opentelemetry-collector
that referenced
this pull request
Jul 5, 2024
swiatekm
pushed a commit
to swiatekm/opentelemetry-collector
that referenced
this pull request
Oct 9, 2024
* Updated default collector version * Updated examples
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Receiver will be loaded through config.go instead of viper.