deprecate exporter API in obsreport #8493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The functionality has been moved into exporter helper. This is part of Signed-off-by: Alex Boten <[email protected]>
Signed-off-by: Alex Boten <[email protected]>
Codecov ReportPatch coverage is
📢 Thoughts on this report? Let us know!. |
mx-psi
approved these changes
Sep 20, 2023
djaglowski
approved these changes
Sep 20, 2023
Signed-off-by: Alex Boten <[email protected]>
dmitryax
reviewed
Sep 20, 2023
Comment on lines
+20
to
+22
| - `obsreport.Exporter` -> `exporterhelper.Exporter` | ||
| - `obsreport.ExporterSettings` -> `exporterhelper.Settings` | ||
| - `obsreport.NewExporter` -> `exporterhelper.New` |
There was a problem hiding this comment.
I think the new API naming is confusing. It still provides the functionality for telemetry reporting but the names don't reflect it anymore. Should we move it exporterhelper/obsreport instead?
codeboten
pushed a commit
that referenced
this pull request
Sep 20, 2023
These deprecated methods/structs have been moved to processorhelper: - `obsreport.BuildProcessorCustomMetricName` -> `processorhelper.BuildCustomMetricName` - `obsreport.Processor` -> `processorhelper.ObsReport` - `obsreport.ProcessorSettings` -> `processorhelper.ObsReportSettings` - `obsreport.NewProcessor` -> `processorhelper.NewObsReport` Same as the change for the exporter, no functional changes just moving code over to the new location. ~Follows #8493 --------- Signed-off-by: Alex Boten <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The functionality has been moved into exporter helper. This is part of #8492
There is no functional changes, just:
obsreporttoexporterhelperobsreport.Exporter,obsreport.ExporterSettings,obsreport.NewExporterobsreport.Exporter->exporterhelper.Exporterobsreport.ExporterSettings->exporterhelper.Settingsobsreport.NewExporter->exporterhelper.New