deprecate processor API in obsreport #8496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage is 📢 Thoughts on this report? Let us know!. |
codeboten
force-pushed
the
codeboten/obsreport-processor
branch
from
df40229 to
d5c813d
Compare
codeboten
force-pushed
the
codeboten/obsreport-processor
branch
2 times, most recently
from
bb9e22d to
d431e72
Compare
These deprecated methods/structs have been moved to processorhelper: - `obsreport.BuildProcessorCustomMetricName` -> `processorhelper.BuildCustomMetricName` - `obsreport.Processor` -> `processorhelper.Processor` - `obsreport.ProcessorSettings` -> `processorhelper.Settings` - `obsreport.NewProcessor` -> `processorhelper.New` Same as the change for the exporter, no functional changes just moving code over to the new location. Signed-off-by: Alex Boten <[email protected]>
codeboten
force-pushed
the
codeboten/obsreport-processor
branch
from
d431e72 to
01e612e
Compare
Signed-off-by: Alex Boten <[email protected]>
dmitryax
approved these changes
Sep 20, 2023
codeboten
pushed a commit
that referenced
this pull request
Sep 21, 2023
These deprecated methods/structs have been moved to receiverhelper and scraperhelper: - `obsreport.Receiver` -> `receiverhelper.ObsReport` - `obsreport.ReceiverSettings` -> `receiverhelper.ObsReportSettings` - `obsreport.NewReceiver` -> `receiverhelper.NewObsReport` - `obsreport.Scraper` -> `scraperhelper.ObsReport` - `obsreport.ScraperSettings` -> `scraperhelper.ObsReportSettings` - `obsreport.NewScraper` -> `scraperhelper.NewObsReport` ~Follows #8496~ Signed-off-by: Alex Boten <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These deprecated methods/structs have been moved to processorhelper:
obsreport.BuildProcessorCustomMetricName->processorhelper.BuildCustomMetricNameobsreport.Processor->processorhelper.ObsReportobsreport.ProcessorSettings->processorhelper.ObsReportSettingsobsreport.NewProcessor->processorhelper.NewObsReportSame as the change for the exporter, no functional changes just moving code over to the
new location.
Follows #8493