Implement the slog Handler functionality #5314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrAlias
added
Skip Changelog
MrAlias
force-pushed
the
grp-attr-handler
branch
from
3751e72 to
35a1789
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5314 +/- ##
=======================================
+ Coverage 61.3% 61.6% +0.2%
=======================================
Files 186 186
Lines 11253 11382 +129
=======================================
+ Hits 6907 7019 +112
- Misses 4147 4161 +14
- Partials 199 202 +3
|
MrAlias
commented
Mar 21, 2024
XSAM
reviewed
Mar 24, 2024
Co-authored-by: Sam Xie <[email protected]>
XSAM
approved these changes
Mar 25, 2024
pellared
approved these changes
Mar 28, 2024
pellared
reviewed
Mar 28, 2024
pellared
reviewed
Mar 28, 2024
pellared
approved these changes
Mar 28, 2024
Co-authored-by: Robert Pająk <[email protected]>
This was referenced Mar 28, 2024
Closed
Closed
jba
reviewed
Apr 8, 2024
| New: func() any { | ||
| // Based on slog research (https://go.dev/blog/slog#performance), 95% | ||
| // of use-cases will use 5 or less attributes. | ||
| return newKVBuffer(5) |
There was a problem hiding this comment.
I used 5 for the array inside a Record because there was a tradeoff: using too much space would hurt performance. There's no similar tradeoff here, so you could make this a bit larger. Maybe 10?
| if b == nil { | ||
| return nil | ||
| } | ||
| return &kvBuffer{data: slices.Clone(b.data)} |
There was a problem hiding this comment.
You lose any extra capacity when you clone b.data, so the subsequent AddAttrs will always allocate. (I think.)
In general though, it's probably best not to worry too much about these details. You can always tweak the performance later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #5195
This adds the types that hold groups and attributes within the
Handler. ThekvBufferis just a wrapper around[]log.KeyValueandgroupis a linked list of embedded group structure (see type comment fornextfield for mapping information).This does not include complete coverage of the added functionality. That is left for a follow-on PR. See #5195 for planned tests.