Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multi-logged integration tests to otelslog #5329

Merged
merged 3 commits into from
Mar 29, 2024

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Mar 28, 2024

Follow up to #5314

Part of #5195

Copy the testing framework from slogtest and use it to test the otelslog.Handler functionality complexity not tested by the base slogtest package.

@MrAlias MrAlias added Skip Changelog Allow PR to succeed without requiring an addition to the CHANGELOG bridge: slog Related to the slog bridge labels Mar 28, 2024
@MrAlias MrAlias mentioned this pull request Mar 28, 2024
8 tasks
Copy link

codecov bot commented Mar 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.8%. Comparing base (336d5b6) to head (3eeced9).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #5329     +/-   ##
=======================================
+ Coverage   61.7%   61.8%   +0.1%     
=======================================
  Files        186     186             
  Lines      11388   11388             
=======================================
+ Hits        7032    7049     +17     
+ Misses      4153    4137     -16     
+ Partials     203     202      -1     

see 1 file with indirect coverage changes

@MrAlias MrAlias marked this pull request as ready for review March 28, 2024 19:00
@MrAlias MrAlias requested a review from a team March 28, 2024 19:00
@MrAlias MrAlias merged commit 59ebbee into open-telemetry:main Mar 29, 2024
23 checks passed
@MrAlias MrAlias deleted the multi-otelslog-tests branch March 29, 2024 19:21
@MrAlias MrAlias added this to the v1.25.0 milestone Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bridge: slog Related to the slog bridge Skip Changelog Allow PR to succeed without requiring an addition to the CHANGELOG
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants