Fixed Labels with sha256 image ref #2238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yuri Sa <[email protected]>
Signed-off-by: Yuri Sa <[email protected]>
swiatekm
approved these changes
Oct 17, 2023
pavolloffay
reviewed
Oct 17, 2023
| Namespace: collectorNamespace, | ||
| }, | ||
| Spec: v1alpha1.OpenTelemetryCollectorSpec{ | ||
| Image: "ghcr.io/open-telemetry/opentelemetry-operator/opentelemetry-operator:0.81.0@sha256:c6671841470b83007e0553cdadbc9d05f6cfe17b3ebe9733728dc4a579a5b532", |
There was a problem hiding this comment.
Could you please add a test case for otel/opentelemetry-collector-contrib@sha256:c6671841470b83007e0553cdadbc9d05f6cfe17b3ebe9733728dc4a579a5b532 - it was reported in the issue this PR resolves
Signed-off-by: Yuri Sa <[email protected]>
tcoville-coveo
approved these changes
Oct 18, 2023
Signed-off-by: Yuri Sa <[email protected]>
pavolloffay
approved these changes
Oct 18, 2023
Signed-off-by: Yuri Sa <[email protected]>
Signed-off-by: Yuri Sa <[email protected]>
Signed-off-by: Yuri Sa <[email protected]>
ItielOlenick
pushed a commit
to ItielOlenick/opentelemetry-operator
that referenced
this pull request
May 1, 2024
* Fixed Labels with sha256 image ref Signed-off-by: Yuri Sa <[email protected]> * Fixed Labels with sha256 image ref Signed-off-by: Yuri Sa <[email protected]> * Added required unit tests Signed-off-by: Yuri Sa <[email protected]> * Added required unit tests Signed-off-by: Yuri Sa <[email protected]> * Changed unit tests Signed-off-by: Yuri Sa <[email protected]> * Changed unit tests Signed-off-by: Yuri Sa <[email protected]> * Changed unit tests Signed-off-by: Yuri Sa <[email protected]> --------- Signed-off-by: Yuri Sa <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixed the labeling process which was broken at the moment to capture the current image tag when the users set the sha256 reference.
Link to tracking Issue:
resolves #1982
Testing:
Created a test using an image being declared with a sha256 and checked if there was a label with only the version number.
Documentation: