Fixed Labels with sha256 image ref

.chloggen/bug-fix-labeling-process.yaml

@@ -0,0 +1,16 @@
+# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
+change_type: bug_fix
+
+# The name of the component, or a single word describing the area of concern, (e.g. operator, target allocator, github action)
+component: Operator
+
+# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
+note: Fixed the labeling process which was broken at the moment to capture the current image tag when the users set the sha256 reference. 
+
+# One or more tracking issues related to the change
+issues: [1982]
+
+# (Optional) One or more lines of additional information to render under the primary note.
+# These lines will be padded with 2 spaces and then inserted directly into the document.
+# Use pipe (|) for multiline entries.
+subtext: ""

internal/manifests/collector/labels.go

@@ -33,6 +33,7 @@ func isFilteredLabel(label string, filterLabels []string) bool {
 
 // Labels return the common labels to all objects that are part of a managed OpenTelemetryCollector.
 func Labels(instance v1alpha1.OpenTelemetryCollector, name string, filterLabels []string) map[string]string {
+	var versionLabel string
 	// new map every time, so that we don't touch the instance's label
 	base := map[string]string{}
 	if nil != instance.Labels {
@@ -48,9 +49,17 @@ func Labels(instance v1alpha1.OpenTelemetryCollector, name string, filterLabels
 	}
 
 	version := strings.Split(instance.Spec.Image, ":")
-	if len(version) > 1 {
+	for _, v := range version {
+		if strings.HasSuffix(v, "@sha256") {
+			versionLabel = strings.TrimSuffix(v, "@sha256")
+		}
+	}
+	switch lenVersion := len(version); lenVersion {
+	case 3:
+		base["app.kubernetes.io/version"] = versionLabel
+	case 2:
 		base["app.kubernetes.io/version"] = version[len(version)-1]
-	} else {
+	default:
 		base["app.kubernetes.io/version"] = "latest"
 	}
 

internal/manifests/collector/labels_test.go

@@ -49,7 +49,26 @@ func TestLabelsCommonSet(t *testing.T) {
 	assert.Equal(t, "opentelemetry", labels["app.kubernetes.io/part-of"])
 	assert.Equal(t, "opentelemetry-collector", labels["app.kubernetes.io/component"])
 }
+func TestLabelsSha256Set(t *testing.T) {
+	// prepare
+	otelcol := v1alpha1.OpenTelemetryCollector{
+		ObjectMeta: metav1.ObjectMeta{
+			Name:      collectorName,
+			Namespace: collectorNamespace,
+		},
+		Spec: v1alpha1.OpenTelemetryCollectorSpec{
+			Image: "ghcr.io/open-telemetry/opentelemetry-operator/opentelemetry-operator:0.81.0@sha256:c6671841470b83007e0553cdadbc9d05f6cfe17b3ebe9733728dc4a579a5b532",
+		},
+	}
 
+	// test
+	labels := Labels(otelcol, collectorName, []string{})
+	assert.Equal(t, "opentelemetry-operator", labels["app.kubernetes.io/managed-by"])
+	assert.Equal(t, "my-ns.my-instance", labels["app.kubernetes.io/instance"])
+	assert.Equal(t, "0.81.0", labels["app.kubernetes.io/version"])
+	assert.Equal(t, "opentelemetry", labels["app.kubernetes.io/part-of"])
+	assert.Equal(t, "opentelemetry-collector", labels["app.kubernetes.io/component"])
+}
 func TestLabelsTagUnset(t *testing.T) {
 	// prepare
 	otelcol := v1alpha1.OpenTelemetryCollector{