-
Notifications
You must be signed in to change notification settings - Fork 674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply breaking changes to Span API (from Sampling OTEP 0006) #132
Comments
Related #134 (also part of the same OTEP, but that one is not breaking) |
When removing opentelemetry-python/opentelemetry-api/src/opentelemetry/trace/__init__.py Lines 201 to 216 in e53edd5
|
Started the work here #259 |
On the following:
It's currently possible for a |
@codeboten No, the OTEP is confusingly worded here: This is about adding span attributes right when creating the span so that the sampler can e.g. sample out all spans that have a |
This OTEP was also already "implemented" in the spec, see https://github.com/open-telemetry/opentelemetry-specification/blob/master/specification/api-tracing.md#span-creation:
|
* feat(plugin): add supportedVersions property Closes open-telemetry#132 Signed-off-by: Olivier Albertini <[email protected]> * fix: add recommendations from markwolff from mayurkale22 Signed-off-by: Olivier Albertini <[email protected]>
Even though we don't support sampling yet, the following already applies:
Reference:
The text was updated successfully, but these errors were encountered: