Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to set explicit start & end time for span #134

Closed
griels opened this issue Sep 11, 2019 · 3 comments · Fixed by #179
Closed

Add ability to set explicit start & end time for span #134

griels opened this issue Sep 11, 2019 · 3 comments · Fixed by #179
Labels
api Affects the API package. good first issue Good first issue tracing

Comments

@griels
Copy link

griels commented Sep 11, 2019

This is present in other implementations.
For example, Java has spanBuilder.withStartTimestamp.

It is crucial for situations where the start time is only known after an event has completed, for example when marshalling a span from a 'foreign' tracing system (this is my situation).
@Oberon00
Copy link
Member

Spec reference: https://github.com/open-telemetry/oteps/blob/master/text/0002-remove-spandata.md

@griels
Copy link
Author

griels commented Sep 11, 2019

Great, sounds like it's on the todo list :) Thanks.

@c24t c24t added api Affects the API package. tracing labels Sep 11, 2019
@Oberon00 Oberon00 mentioned this issue Sep 12, 2019
Closed
@johananl
Copy link
Contributor

Same for setting an explicit end time when calling finish() on a span. I guess we can handle both in this issue.

@Oberon00 Oberon00 changed the title Add ability to set start time for span Add ability to set explicit start & end time for span Sep 25, 2019
@Oberon00 Oberon00 mentioned this issue Sep 25, 2019
Closed
@c24t c24t added the good first issue Good first issue label Sep 25, 2019
@hectorhdzg hectorhdzg mentioned this issue Sep 26, 2019
Merged
This was referenced Nov 15, 2019
Merged
Merged
srikanthccv pushed a commit to srikanthccv/opentelemetry-python that referenced this issue Nov 1, 2020
@mayurkale22
docs: improve readme (open-telemetry#134)
dbb39f4 
* docs: improve readme

* docs: improve readme
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api Affects the API package. good first issue Good first issue tracing
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Span add override parameters for start_time and end_time hectorhdzg/opentelemetry-python
4 participants
@Oberon00 @griels @johananl @c24t