Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conform to RFC 2 - Remove SpanData #169

Closed
bg451 opened this issue Sep 24, 2019 · 2 comments
Closed

Conform to RFC 2 - Remove SpanData #169

bg451 opened this issue Sep 24, 2019 · 2 comments

Comments

@bg451
Copy link
Member

bg451 commented Sep 24, 2019 •
edited
Loading

Howdy all, wanted to throw this into your backlogs. SpanData has officially been removed from the specification per RFC 2. Here's the specification diff but to summarize, SpanData was removed from the API and, in its place, start span needs to accept an optional start timestamp. End span also needs to accept an optional end timestamp.
@Oberon00
Copy link
Member

We never had SpanData in Python. The rest is already covered in #134, so closing this.

@bg451
Copy link
Member Author

bg451 commented Sep 25, 2019

Awesome!

srikanthccv pushed a commit to srikanthccv/opentelemetry-python that referenced this issue Nov 1, 2020
@mayurkale22
fix: add default UNSAMPLED TraceOptions in case of INVALID_SPAN_CONTE…
41e0d05 
…XT (open-telemetry#169)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Oberon00 @bg451