Fix saithrift build issue for Bookworm SONiC #1974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change fixes issue #1973 |
|
@saiarcot895 @vivekrnv please review |
Keshavg-marvell
force-pushed
the
saithrift_build_bookworm
branch
from
2312f1d to
7aecbf2
Compare
vivekrnv
reviewed
Mar 1, 2024
| @@ -0,0 +1,2 @@ | |||
| #compatiable with bookworm python 3.11 environment and saithriftv2 build with python3 | |||
There was a problem hiding this comment.
Update the comment to remove saithriftv2
There was a problem hiding this comment.
Thanks. I will remove this.
debian/copy_installer.sh
Outdated
| else | ||
| if [ $(lsb_release -sr) -ge 11 ] | ||
| if [ $(lsb_release -sr) -eq 12 ] |
There was a problem hiding this comment.
I think we can make python3-saithrift-bookworm.install default for all the version >= 12. What do you think?
There was a problem hiding this comment.
Sure, I will make python3-saithrift-bookworm.install default for version >= 12
saithrift package is getting installed at different location for bookworm. Taking care it using copy_installer.sh script. This change fixes build issue for both saithriftv1 and saithriftv2 Signed-off-by: Keshav Gupta <[email protected]>
Keshavg-marvell
force-pushed
the
saithrift_build_bookworm
branch
from
7aecbf2 to
8fe2d56
Compare
vivekrnv
approved these changes
Mar 5, 2024
saiarcot895
approved these changes
Mar 5, 2024
kcudnik
approved these changes
Mar 6, 2024
JaiOCP
pushed a commit
to JaiOCP/SAI
that referenced
this pull request
Mar 7, 2024
saithrift package is getting installed at different location for bookworm. Taking care it using copy_installer.sh script. This change fixes build issue for both saithriftv1 and saithriftv2 Signed-off-by: Keshav Gupta <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
saithrift package is getting installed at different location for bookworm. Taking care it using copy_installer.sh script.
This change fixes build issue for both saithriftv1 and saithriftv2.