Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CODEOWNERS, remove .pullapprove.yml #70

Merged
merged 1 commit into from
Nov 23, 2021
Merged

Add CODEOWNERS, remove .pullapprove.yml #70

merged 1 commit into from
Nov 23, 2021

Conversation

jdolitsky
Copy link
Member

No description provided.

@AkihiroSuda
Copy link
Member

What's the context?

@dmcgowan
Copy link
Member

I assume to get rid of pullapprove. What does CODEOWNERS file add over just replacing pullapprove with github's threshold approve?

@stevvooe
Copy link
Contributor

Doesn't CODEOWNERS drive github's feature?

stevvooe
stevvooe approved these changes Nov 11, 2021
View reviewed changes
Copy link
Contributor

@stevvooe stevvooe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah
Copy link
Member

I don't think the CODEOWNERS is strictly needed to make the feature work; configuring "number of approvals" should probably be enough. That said, CODEOWNERS will allow automatically request a review from those listed.

Not sure though if "Require review from Code Owners" will force all code owners to leave a review (I guess we only need two out of that list)

Screenshot 2021-11-11 at 19 54 49

@thaJeztah thaJeztah mentioned this pull request Nov 12, 2021
Merged
vbatts
vbatts approved these changes Nov 22, 2021
View reviewed changes
Copy link
Member

@vbatts vbatts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it must be configured in the repo settings.
But LGTM for once we get that done (cc @caniszczyk )

@caniszczyk
Copy link
Contributor

LGTM (enabled the "Require a pull request before merging") setting

@vbatts vbatts merged commit 20c89ec into opencontainers:master Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbatts vbatts vbatts approved these changes

@stevvooe stevvooe stevvooe approved these changes

@dmcgowan dmcgowan dmcgowan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@jdolitsky @AkihiroSuda @dmcgowan @stevvooe @thaJeztah @caniszczyk @vbatts