Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CODEOWNERS #168

Merged
merged 1 commit into from
Nov 12, 2021
Merged

Add CODEOWNERS #168

merged 1 commit into from
Nov 12, 2021

Conversation

jdolitsky
Copy link
Member

No description provided.

Signed-off-by: Josh Dolitsky <[email protected]>
Copy link
Collaborator

@rhatdan rhatdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rhatdan
Copy link
Collaborator

rhatdan commented Nov 11, 2021

@kolyshkin @thaJeztah @mrunalp PTAL

Copy link
Collaborator

@kolyshkin kolyshkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah
Copy link
Member

Not a blocker, but I'm still a bit on the fence on the added value of the CODEOWNERS file, as that file mostly adds value for more "mono-repos", where specific parts of the code have "owners". In this repository, that's not the case, so it rather duplicates the MAINTAINERS file (but will have to be kept in sync); also see opencontainers/go-digest#70 (comment)

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rhatdan rhatdan merged commit 0cb05ae into opencontainers:main Nov 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants