-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat]curvefs: add bs create volume snapshot #2663
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe the problem is not clearly described, what I want to achieve is this:
curve/tools/snaptool/curltool.py
Lines 85 to 95 in 6a74151
def create_snapshot(user, filename, snapshotname): | |
if user is None or filename is None or snapshotname is None: | |
print('user, filename, snapshotname need') | |
return | |
params = {'Action':'CreateSnapshot', 'Version':'0.0.6', 'User':user, 'File':filename, 'Name':snapshotname} | |
jsonobj = query(params) | |
if jsonobj['Code'] != '0': | |
print("create snapshot fail, ecode=%s, etext=%s" % (jsonobj['Code'], errcodelist[jsonobj['Code']])) | |
return | |
print("create snapshot success, UUID=%s" % jsonobj['UUID']) |
Signed-off-by: ApiaoSamaa <[email protected]>
cicheck |
There should be a problem with your implementation. What you want to achieve is this, which should be to create an http request. |
Hi! I found the problem, which was caused due to my being misled into calling the wrong interface, and now two solutions come into my mind: 1. The client contracts an http packet. 2. Add a new roc interface. If you want a uniform format, we may use solution 2, but 1 is easier to achieve. @Cyber-SiKu |
Option 1 is just fine, you can refer to this pr |
@ApiaoSamaa Did you encounter any problems? |
pls fix dco && conflicts |
Do you want to continue this issue? |
Sorry for my delay... I might quit TuT |
pr stale,you can reopen it later. |
What problem does this PR solve?
Issue Number: #2585
Problem Summary:
What is changed and how it works?
What's Changed:
How it Works:
Side effects(Breaking backward compatibility? Performance regression?):
Check List