Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat]curvefs: add bs create volume snapshot #2663

Closed
wants to merge 2 commits into from
Closed

[feat]curvefs: add bs create volume snapshot #2663

wants to merge 2 commits into from

Conversation

ApiaoSamaa
Copy link

@ApiaoSamaa ApiaoSamaa commented Aug 1, 2023

What problem does this PR solve?

Issue Number: #2585

Problem Summary:

What is changed and how it works?

What's Changed:

How it Works:

Side effects(Breaking backward compatibility? Performance regression?):

Check List

  • Relevant documentation/comments is changed or added
  • I acknowledge that all my contributions will be made under the project's license

Copy link
Contributor

@Cyber-SiKu Cyber-SiKu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe the problem is not clearly described, what I want to achieve is this:

def create_snapshot(user, filename, snapshotname):
if user is None or filename is None or snapshotname is None:
print('user, filename, snapshotname need')
return
params = {'Action':'CreateSnapshot', 'Version':'0.0.6', 'User':user, 'File':filename, 'Name':snapshotname}
jsonobj = query(params)
if jsonobj['Code'] != '0':
print("create snapshot fail, ecode=%s, etext=%s" % (jsonobj['Code'], errcodelist[jsonobj['Code']]))
return
print("create snapshot success, UUID=%s" % jsonobj['UUID'])

@ApiaoSamaa
Copy link
Author

cicheck

@ApiaoSamaa ApiaoSamaa requested a review from Cyber-SiKu August 22, 2023 16:14
@Cyber-SiKu
Copy link
Contributor

Maybe the problem is not clearly described, what I want to achieve is this:

def create_snapshot(user, filename, snapshotname):
if user is None or filename is None or snapshotname is None:
print('user, filename, snapshotname need')
return
params = {'Action':'CreateSnapshot', 'Version':'0.0.6', 'User':user, 'File':filename, 'Name':snapshotname}
jsonobj = query(params)
if jsonobj['Code'] != '0':
print("create snapshot fail, ecode=%s, etext=%s" % (jsonobj['Code'], errcodelist[jsonobj['Code']]))
return
print("create snapshot success, UUID=%s" % jsonobj['UUID'])

There should be a problem with your implementation. What you want to achieve is this, which should be to create an http request.

@ApiaoSamaa
Copy link
Author

Hi! I found the problem, which was caused due to my being misled into calling the wrong interface, and now two solutions come into my mind: 1. The client contracts an http packet. 2. Add a new roc interface. If you want a uniform format, we may use solution 2, but 1 is easier to achieve. @Cyber-SiKu

@Cyber-SiKu
Copy link
Contributor

Hi! I found the problem, which was caused due to my being misled into calling the wrong interface, and now two solutions come into my mind: 1. The client contracts an http packet. 2. Add a new roc interface. If you want a uniform format, we may use solution 2, but 1 is easier to achieve. @Cyber-SiKu

Option 1 is just fine, you can refer to this pr

@Cyber-SiKu
Copy link
Contributor

@ApiaoSamaa Did you encounter any problems?

@Cyber-SiKu
Copy link
Contributor

pls fix dco && conflicts

@SeanHai
Copy link
Contributor

SeanHai commented Nov 7, 2023

Do you want to continue this issue?

@ApiaoSamaa
Copy link
Author

Do you want to continue this issue?↳

Sorry for my delay... I might quit TuT

@wuhongsong
Copy link
Contributor

pr stale,you can reopen it later.

@wuhongsong wuhongsong closed this Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants