-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add bs delete volume recover&clone command #2713
Conversation
I believe there is no problem with the logic of the code, but the printing form may need to be standardized. The implementation in your PR is to ask the user yes/no, and then print it line by line, which is different from the printing form of other commands(e.g. print a table with several rows). But how to print is not up to me, ask @Cyber-SiKu for advice. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
those are my personal opinions. You should better discuss this with someone with a merge permission.
tools-v2/pkg/cli/command/curvebs/delete/volume/clone_or_recover.go
Outdated
Show resolved
Hide resolved
tools-v2/pkg/cli/command/curvebs/delete/volume/clone_or_recover.go
Outdated
Show resolved
Hide resolved
Signed-off-by: setcy <[email protected]>
cicheck |
Please add the usage of the command in the readme |
What problem does this PR solve?
add
bs delete volume recover
andbs delete volume clone
commandIssue Number:
#2580
#2581
Problem Summary:
What is changed and how it works?
What's Changed:
How it Works:
Side effects(Breaking backward compatibility? Performance regression?):
Check List