fix(controller, probe): fix sysfs probe and controller options #504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- set controller options in device list command - return sysfs probe to prevent null pointer exception Signed-off-by: Akhil Mohan <[email protected]>
akhilerm
force-pushed
the
fix-controller-probe
branch
from
7055003 to
dc98a56
Compare
akhilerm
referenced
this pull request
Oct 22, 2020
* add config file as argument instead of doing with the default hardcoded filepath * fix test cases for config options Signed-off-by: Akhil Mohan <[email protected]>
kmova
approved these changes
Oct 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Akhil Mohan [email protected]
Pull Request template
Why is this PR required? What issue does it fix?:
devce listcommand which caused the command to not list blockdevice resources.What this PR does?:
Does this PR require any upgrade changes?:
No
If the changes in this PR are manually verified, list down the scenarios covered::
Any additional information for your reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs
Checklist:
<type>(<scope>): <subject>