Stackoverflow fix #1742

debris · 2016-07-27T13:51:01Z

…_fix

gavofyork · 2016-07-28T08:26:06Z

this alters the user-visible JSONRPC format; can we do a follow-up PR prior to 1.3 to reinstate the original trace format?

debris · 2016-07-28T08:36:39Z

Only trace_call, trace_rawTransaction and trace_replayTransaciton are changed and there is no way of preserving the old format cause serialization of data will overflow the stack.

rawTransaction and replayTransaction were merged 2 days ago, so they were not yet in release version. The only broken method is trace_call, but afaik it's not used by exchanges/block explorers.

coveralls · 2016-07-28T08:48:18Z

Coverage decreased (-0.2%) to 86.689% when pulling 955dc53 on stackoverflow_fix into 6b1e722 on master.

gavofyork · 2016-07-28T08:51:26Z

it is used by some of my ui, and in general the heirarchical JSON more closely represents the underlying information. i'd prefer not to cut any corners on standards just because serde's model is inadequate. ultimately, these should be adopted across clients and it's hard to make a case for a substandard API/format on the argument of "a library of one of the implementation makes this format easier".

debris · 2016-07-28T09:04:22Z

it is used by some of my ui, and in general the heirarchical JSON more closely represents the underlying information

I agree, but this model does not work now. It overflows very often when serializing to rlp / serializing to json

i'd prefer not to cut any corners on standards just because serde's model is inadequate.

We already have one format of returning traces on which we agreed on few months ago. This format is already used be exchanges / block explorers. I don't see a reason to have another one

gavofyork · 2016-07-28T09:33:18Z

they fulfil two different needs though. the format to which you linked must handle the case of returning a collection of individual messages/creates/suicides from across many transactions.

when tracing a single individual transaction, that is not needed; rather a hierarchical/recursive format makes more sense since it directly reflects the structure of the call graph.

this model does not work now

i repeat: i'd prefer not to cut any corners on standards just because serde's model is inadequate.

arkpar · 2016-07-28T10:50:05Z

I'd prefer to have a single output format for all types of queries. We might also want to filter individual tx traces by address in the future for example.

gavofyork · 2016-07-28T11:46:02Z

we have different outputs for different RPC calls - it's all about fitting the format to the structure of the data. this is no different.

* executive tracer builds flat traces without intermediate struct * temporarilt commented out tests for traces * fixed new way of building trace address * fixed new way of building trace address * updating state tests with flat tracing in progress * fixed flat tracing tests * fixed compiling ethcore-rpc with new flat traces * removed warnings from ethcore module * remove unused data structures

* Don't try to sync to ancient blocks * Parallel block body download * Fixed reading chunked EIP8 handshake (#1712) * Fixed reading chunked EIP8 handshake * Added missing break * Disconnect peers on a fork * Updated json-ipc-server * Combine mining queue and enabled into single locked datum (#1749) * Combine mining queue and enabled into single locked datum Additional tracing. * Fix bug uncovered by test. * Fix typo * Remove unneeded log initialisation in test. * fix failing test (#1756) * Fixed test * Suicides tracing (#1688) * tracing suicide * fixed #1635 * fixed typo * Stackoverflow #1686 (#1698) * flat trace serialization * tracing finds transaction which creates contract * flatten traces before inserting them to the db * Trace other types of calls (#1727) * Trace through DELEGATECALL and CALLCODE Add them to the JSON output and RLP database store. * Fix tests. * Fix all tests. * Fix one more test. * filtering transactions toAddress includes contract creation (#1697) * tracing finds transaction which creates contract * comma cleanup Remove when following `}`s, add to final entries. * Various improvements to tracing & diagnostics. (#1707) * Various improvements to tracing & diagnostics. - Manage possibility of `Account` not having code for `PodAccount` - New RPC: `trace_sendRawTransaction` - See raw transaction dump when inspecting over RPC * Fix test * Remove one of the dupe error messages * Remove unneeded `&`s * Reformat and extremely minor optimisation * Minor optimisation * Remove unneeded let * Fix tests. * Additional fix. * Minor rename. * Bowing to the pressure. * Stackoverflow fix (#1742) * executive tracer builds flat traces without intermediate struct * temporarilt commented out tests for traces * fixed new way of building trace address * fixed new way of building trace address * updating state tests with flat tracing in progress * fixed flat tracing tests * fixed compiling ethcore-rpc with new flat traces * removed warnings from ethcore module * remove unused data structures

* Suicides tracing (#1688) * tracing suicide * fixed #1635 * fixed typo * Stackoverflow #1686 (#1698) * flat trace serialization * tracing finds transaction which creates contract * flatten traces before inserting them to the db * Trace other types of calls (#1727) * Trace through DELEGATECALL and CALLCODE Add them to the JSON output and RLP database store. * Fix tests. * Fix all tests. * Fix one more test. * filtering transactions toAddress includes contract creation (#1697) * tracing finds transaction which creates contract * comma cleanup Remove when following `}`s, add to final entries. * Various improvements to tracing & diagnostics. (#1707) * Various improvements to tracing & diagnostics. - Manage possibility of `Account` not having code for `PodAccount` - New RPC: `trace_sendRawTransaction` - See raw transaction dump when inspecting over RPC * Fix test * Remove one of the dupe error messages * Remove unneeded `&`s * Reformat and extremely minor optimisation * Minor optimisation * Remove unneeded let * Fix tests. * Additional fix. * Minor rename. [ci:skip] * Bowing to the pressure. * Stackoverflow fix (#1742) * executive tracer builds flat traces without intermediate struct * temporarilt commented out tests for traces * fixed new way of building trace address * fixed new way of building trace address * updating state tests with flat tracing in progress * fixed flat tracing tests * fixed compiling ethcore-rpc with new flat traces * removed warnings from ethcore module * remove unused data structures

debris added 5 commits July 27, 2016 13:36

executive tracer builds flat traces without intermediate struct

e9c493d

temporarilt commented out tests for traces

dcccb62

fixed new way of building trace address

b119b44

fixed new way of building trace address

1d8966a

updating state tests with flat tracing in progress

6dbe7b3

debris added the A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. label Jul 27, 2016

debris added 5 commits July 28, 2016 09:34

fixed flat tracing tests

49438a9

Merge branch 'master' of github.com:ethcore/parity into stackoverflow…

e9b307b

…_fix

fixed compiling ethcore-rpc with new flat traces

c868a88

removed warnings from ethcore module

0020d11

remove unused data structures

955dc53

debris added A0-pleasereview 🤓 Pull request needs code review. and removed A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. labels Jul 28, 2016

gavofyork added A6-mustntgrumble 💦 Pull request has areas for improvement. The author need not address them before merging. and removed A0-pleasereview 🤓 Pull request needs code review. labels Jul 28, 2016

gavofyork merged commit 9746b94 into master Jul 28, 2016

gavofyork deleted the stackoverflow_fix branch July 28, 2016 18:31

debris mentioned this pull request Jul 29, 2016

tracing backport #1770

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Stackoverflow fix #1742

Stackoverflow fix #1742

debris commented Jul 27, 2016 •

edited

Loading

gavofyork commented Jul 28, 2016

debris commented Jul 28, 2016 •

edited

Loading

coveralls commented Jul 28, 2016 •

edited

Loading

gavofyork commented Jul 28, 2016 •

edited

Loading

debris commented Jul 28, 2016

gavofyork commented Jul 28, 2016 •

edited

Loading

arkpar commented Jul 28, 2016

gavofyork commented Jul 28, 2016 •

edited

Loading

Stackoverflow fix #1742

Stackoverflow fix #1742

Conversation

debris commented Jul 27, 2016 • edited Loading

gavofyork commented Jul 28, 2016

debris commented Jul 28, 2016 • edited Loading

coveralls commented Jul 28, 2016 • edited Loading

gavofyork commented Jul 28, 2016 • edited Loading

debris commented Jul 28, 2016

gavofyork commented Jul 28, 2016 • edited Loading

arkpar commented Jul 28, 2016

gavofyork commented Jul 28, 2016 • edited Loading

debris commented Jul 27, 2016 •

edited

Loading

debris commented Jul 28, 2016 •

edited

Loading

coveralls commented Jul 28, 2016 •

edited

Loading

gavofyork commented Jul 28, 2016 •

edited

Loading

gavofyork commented Jul 28, 2016 •

edited

Loading

gavofyork commented Jul 28, 2016 •

edited

Loading