This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Combine mining queue and enabled into single locked datum #1749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Additional tracing.
gavofyork
added
the
A3-inprogress ⏳
| @@ -413,10 +411,6 @@ impl Client { | |||
| } | |||
| } | |||
|
|
|||
| if self.chain_info().best_block_hash != original_best { | |||
| self.miner.update_sealing(self); | |||
There was a problem hiding this comment.
Why it's not required anymore? Is miner being informed in some other place as well?
There was a problem hiding this comment.
yes self.miner.chain_new_blocks ~12 lines above
gavofyork
added
A0-pleasereview 🤓
arkpar
added
A8-looksgood 🦄
gavofyork
added
A8-looksgood 🦄
| @@ -1899,6 +1899,8 @@ mod tests { | |||
|
|
|||
| #[test] | |||
| fn should_add_transactions_to_queue() { | |||
| log::init_log(); | |||
tomusdrw
added
A6-mustntgrumble 💦
arkpar
pushed a commit
that referenced
this pull request
Jul 29, 2016
* Combine mining queue and enabled into single locked datum Additional tracing. * Fix bug uncovered by test. * Fix typo * Remove unneeded log initialisation in test. [ci:skip]
arkpar
pushed a commit
that referenced
this pull request
Jul 29, 2016
* Combine mining queue and enabled into single locked datum Additional tracing. * Fix bug uncovered by test. * Fix typo * Remove unneeded log initialisation in test.
| // | Make sure to release the locks before calling that method. | | ||
| // -------------------------------------------------------------------------- | ||
| self.update_sealing(chain); | ||
| if enacted.len() == 0 { |
There was a problem hiding this comment.
should be !=? Seems to have opposite behavior of before.
gavofyork
pushed a commit
that referenced
this pull request
Jul 30, 2016
* Don't try to sync to ancient blocks * Parallel block body download * Fixed reading chunked EIP8 handshake (#1712) * Fixed reading chunked EIP8 handshake * Added missing break * Disconnect peers on a fork * Updated json-ipc-server * Combine mining queue and enabled into single locked datum (#1749) * Combine mining queue and enabled into single locked datum Additional tracing. * Fix bug uncovered by test. * Fix typo * Remove unneeded log initialisation in test. * fix failing test (#1756) * Fixed test * Suicides tracing (#1688) * tracing suicide * fixed #1635 * fixed typo * Stackoverflow #1686 (#1698) * flat trace serialization * tracing finds transaction which creates contract * flatten traces before inserting them to the db * Trace other types of calls (#1727) * Trace through DELEGATECALL and CALLCODE Add them to the JSON output and RLP database store. * Fix tests. * Fix all tests. * Fix one more test. * filtering transactions toAddress includes contract creation (#1697) * tracing finds transaction which creates contract * comma cleanup Remove when following `}`s, add to final entries. * Various improvements to tracing & diagnostics. (#1707) * Various improvements to tracing & diagnostics. - Manage possibility of `Account` not having code for `PodAccount` - New RPC: `trace_sendRawTransaction` - See raw transaction dump when inspecting over RPC * Fix test * Remove one of the dupe error messages * Remove unneeded `&`s * Reformat and extremely minor optimisation * Minor optimisation * Remove unneeded let * Fix tests. * Additional fix. * Minor rename. * Bowing to the pressure. * Stackoverflow fix (#1742) * executive tracer builds flat traces without intermediate struct * temporarilt commented out tests for traces * fixed new way of building trace address * fixed new way of building trace address * updating state tests with flat tracing in progress * fixed flat tracing tests * fixed compiling ethcore-rpc with new flat traces * removed warnings from ethcore module * remove unused data structures
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional tracing.