This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
DB WAL size limit #1935
Merged
DB WAL size limit #1935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| db.latest_era().unwrap_or(0) | ||
| let mut client_path = dirs.client_path(genesis_hash, fork_name, *i); | ||
| client_path.push("CURRENT"); | ||
| fs::metadata(&client_path).and_then(|m| m.modified()).ok() | ||
| }).unwrap() |
There was a problem hiding this comment.
Will fail if all paths result in Err -> None should probably be unwrap_or_default
There was a problem hiding this comment.
algo_types can't be empty so this can't panic
There was a problem hiding this comment.
Right, sorry. I thought that there is filter being done there.
tomusdrw
added
A4-gotissues 💥
arkpar
added
A0-pleasereview 🤓
tomusdrw
added
A8-looksgood 🦄
|
isn't WAL meant to be a failsafe in case of bad shutdown? Does limiting the size preserve this behavior? |
|
64MB should be enough for a failsafe. I've tested for unexpected shutdowns on a linux VM and it appears to be working fine. |
arkpar
added a commit
that referenced
this pull request
Sep 11, 2016
* Limit WAL size * Check pruning by db modification date (#1924)
arkpar
added a commit
that referenced
this pull request
Sep 11, 2016
* Fix several RPCs (#1926) * Fix up pending receipts details. * Add support for additional params and registry over RPC. * Fix tests. * Add test, additional fix. Fixes #1932. * Fix up tests. * Fix test. * Fix test. * DB WAL size limit (#1935) * Limit WAL size * Check pruning by db modification date (#1924) * Cache address hash (#1943) * ECIES without MAC (#1948) * Use random IV for ECIES AES * ECIES encrypt/decrypt for a single message * Derive IV from shared secret * Apply settings to column families * fixed #1933 (#1979) * Fixed neighbours collection (#1996) * dapps-hosts configuration * Disabled counter check * always process trie death row on commit, add more tracing * fixed transaction addresses mapping, fixes #1971 * simplified iterator * v1.3.1 * v1.3.1
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set WAL size limit to 64mb
Also includes DB detection fix made in the beta branch.