This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
let mut msgd = vec![0u8; (64 + 16 + plain.len())]; | ||
{ | ||
r.public().copy_to(&mut msgd[0..64]); | ||
let iv = H128::random(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would be nice to remove the IV, too (i.e. just zeroes or the SHA3 of the shared secret) to keep the message minimal. the use case doesn't require a super-high degree of security.
gavofyork
added
A6-mustntgrumble 💦
Pull request has areas for improvement. The author need not address them before merging.
and removed
A0-pleasereview 🤓
Pull request needs code review.
labels
Aug 18, 2016
arkpar
added
A0-pleasereview 🤓
Pull request needs code review.
and removed
A6-mustntgrumble 💦
Pull request has areas for improvement. The author need not address them before merging.
labels
Aug 18, 2016
gavofyork
added
A8-looksgood 🦄
Pull request is reviewed well.
and removed
A0-pleasereview 🤓
Pull request needs code review.
labels
Aug 18, 2016
Merged
arkpar
added a commit
that referenced
this pull request
Sep 11, 2016
* Use random IV for ECIES AES * ECIES encrypt/decrypt for a single message * Derive IV from shared secret
arkpar
added a commit
that referenced
this pull request
Sep 11, 2016
* Fix several RPCs (#1926) * Fix up pending receipts details. * Add support for additional params and registry over RPC. * Fix tests. * Add test, additional fix. Fixes #1932. * Fix up tests. * Fix test. * Fix test. * DB WAL size limit (#1935) * Limit WAL size * Check pruning by db modification date (#1924) * Cache address hash (#1943) * ECIES without MAC (#1948) * Use random IV for ECIES AES * ECIES encrypt/decrypt for a single message * Derive IV from shared secret * Apply settings to column families * fixed #1933 (#1979) * Fixed neighbours collection (#1996) * dapps-hosts configuration * Disabled counter check * always process trie death row on commit, add more tracing * fixed transaction addresses mapping, fixes #1971 * simplified iterator * v1.3.1 * v1.3.1
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.