Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

ECIES without MAC #1948

Merged
merged 3 commits into from
Aug 18, 2016
Merged

ECIES without MAC #1948

merged 3 commits into from
Aug 18, 2016

Conversation

arkpar
Copy link
Collaborator

@arkpar arkpar commented Aug 17, 2016

No description provided.

@arkpar arkpar added the A0-pleasereview 🤓 Pull request needs code review. label Aug 17, 2016
@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 87.001% when pulling ffaae0e on ecies-iv-fix into ccdf80f on master.

let mut msgd = vec![0u8; (64 + 16 + plain.len())];
{
r.public().copy_to(&mut msgd[0..64]);
let iv = H128::random();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would be nice to remove the IV, too (i.e. just zeroes or the SHA3 of the shared secret) to keep the message minimal. the use case doesn't require a super-high degree of security.

@gavofyork gavofyork added A6-mustntgrumble 💦 Pull request has areas for improvement. The author need not address them before merging. and removed A0-pleasereview 🤓 Pull request needs code review. labels Aug 18, 2016
@arkpar arkpar added A0-pleasereview 🤓 Pull request needs code review. and removed A6-mustntgrumble 💦 Pull request has areas for improvement. The author need not address them before merging. labels Aug 18, 2016
@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 87.002% when pulling d972eda on ecies-iv-fix into ccdf80f on master.

@gavofyork gavofyork added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Aug 18, 2016
@gavofyork gavofyork merged commit 8159d74 into master Aug 18, 2016
@gavofyork gavofyork deleted the ecies-iv-fix branch August 18, 2016 16:08
@debris debris mentioned this pull request Aug 25, 2016
arkpar added a commit that referenced this pull request Sep 11, 2016
* Use random IV for ECIES AES

* ECIES encrypt/decrypt for a single message

* Derive IV from shared secret
arkpar added a commit that referenced this pull request Sep 11, 2016
* Fix several RPCs (#1926)

* Fix up pending receipts details.

* Add support for additional params and registry over RPC.

* Fix tests.

* Add test, additional fix.

Fixes #1932.

* Fix up tests.

* Fix test.

* Fix test.

* DB WAL size limit (#1935)

* Limit WAL size

* Check pruning by db modification date (#1924)

* Cache address hash (#1943)

* ECIES without MAC (#1948)

* Use random IV for ECIES AES

* ECIES encrypt/decrypt for a single message

* Derive IV from shared secret

* Apply settings to column families

* fixed #1933 (#1979)

* Fixed neighbours collection (#1996)

* dapps-hosts configuration

* Disabled counter check

* always process trie death row on commit, add more tracing

* fixed transaction addresses mapping, fixes #1971

* simplified iterator

* v1.3.1

* v1.3.1
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants