This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Fixing RPC Filter conversion to EthFilter #2500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomusdrw
added
A0-pleasereview 🤓
arkpar
added
A8-looksgood 🦄
arkpar
reviewed
Oct 7, 2016
| }).collect()).into_iter(); | ||
|
|
||
| vec
There was a problem hiding this comment.
why iter.next().unwrap_or(None) instead of just iter.next()?
There was a problem hiding this comment.
iter.next() returns Option<Option<Vec>> we need Option<Vec>
arkpar
added
A6-mustntgrumble 💦
tomusdrw
added
A6-mustntgrumble 💦
arkpar
added
A8-looksgood 🦄
|
I'm not really familiar with your release schedule, when can I look forward to this fix being in a published version? |
|
@FlySwatter This fix was actually backported to the |
jacogr
added a commit
that referenced
this pull request
Oct 8, 2016
* js: (228 commits) registration in place Backports to master (#2530) lookup hash ethcore_hashContent call single input for commit/filename basic githubhint layout Handle reorganizations in the state cache (#2490) terminate after 30 seconds (#2513) allow updates of the secure token Using pending block only if not old (#2514) Caching optimizations (#2505) rework connection display basic test for manual token Fixed overflow panic in handshake_panic (#2495) Trim password from file (#2503) Fixing RPC Filter conversion to EthFilter (#2500) init token updates take place initial token connection - WIP Fixing error message for transactions (#2496) Adjustable stack size for EVM (#2483) ... # Conflicts: # js/src/dapps/registry/Application/application.js # js/src/dapps/registry/Container.js # js/src/dapps/registry/actions.js # js/src/dapps/registry/reducers.js
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #2485