Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Trim password from file #2503

Merged
merged 2 commits into from
Oct 7, 2016
Merged

Trim password from file #2503

merged 2 commits into from
Oct 7, 2016

Conversation

keorn
Copy link

@keorn keorn commented Oct 6, 2016

Closes #1866

@keorn keorn added A0-pleasereview 🤓 Pull request needs code review. M4-core ⛓ Core client code / Rust. A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. and removed A0-pleasereview 🤓 Pull request needs code review. labels Oct 6, 2016
@keorn keorn added A0-pleasereview 🤓 Pull request needs code review. and removed A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. labels Oct 6, 2016
@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 86.437% when pulling 215aae0 on password-trim into ac0ae24 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 86.433% when pulling 215aae0 on password-trim into ac0ae24 on master.

@NikVolf NikVolf added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Oct 6, 2016
@arkpar arkpar merged commit 5f0ed9d into master Oct 7, 2016
jacogr added a commit that referenced this pull request Oct 8, 2016
@jacogr
Merge branch 'js' into jr-registry-manage-records
83b6a9c 
* js: (228 commits)
  registration in place
  Backports to master (#2530)
  lookup hash
  ethcore_hashContent call
  single input for commit/filename
  basic githubhint layout
  Handle reorganizations in the state cache (#2490)
  terminate after 30 seconds (#2513)
  allow updates of the secure token
  Using pending block only if not old (#2514)
  Caching optimizations (#2505)
  rework connection display
  basic test for manual token
  Fixed overflow panic in handshake_panic (#2495)
  Trim password from file (#2503)
  Fixing RPC Filter conversion to EthFilter (#2500)
  init token updates take place
  initial token connection - WIP
  Fixing error message for transactions (#2496)
  Adjustable stack size for EVM (#2483)
  ...

# Conflicts:
#	js/src/dapps/registry/Application/application.js
#	js/src/dapps/registry/Container.js
#	js/src/dapps/registry/actions.js
#	js/src/dapps/registry/reducers.js
@gavofyork gavofyork deleted the password-trim branch November 3, 2016 11:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
A8-looksgood 🦄 Pull request is reviewed well. M4-core ⛓ Core client code / Rust.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@keorn @coveralls @NikVolf @arkpar