This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
NikVolf
commented
Dec 21, 2017
•
edited
Loading
edited
- call now obliged to specify gas limit
- overall update of wasm-tests and corresponding gas costs
- some environment for calls was fixed to be passed correctly
NikVolf
added
A0-pleasereview 🤓
Pull request needs code review.
M4-core ⛓
Core client code / Rust.
labels
Dec 21, 2017
9 tasks
pepyakin
suggested changes
Dec 21, 2017
ethcore/wasm/src/env.rs
Outdated
@@ -69,17 +69,17 @@ pub const SIGNATURES: &'static [UserFunctionDescriptor] = &[ | |||
), | |||
Static( | |||
"_ccall", | |||
&[I32; 6], | |||
&[I64, I32, I32, I32, I32, I32], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it really a correct signature? In pwasm-std/pwasm-ethereum
it is defined like
pub fn ccall(
gas: i64,
address: *const u8,
val_ptr: *const u8,
input_ptr: *const u8,
input_len: u32,
result_ptr: *mut u8,
result_len: u32,
) → i32;
which have 7 arguments, but in code above it have only 6.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch, regular call lacks dedicated test also
pepyakin
added
A4-gotissues 💥
Pull request is reviewed and has significant issues which must be addressed.
and removed
A0-pleasereview 🤓
Pull request needs code review.
labels
Dec 21, 2017
NikVolf
added
A3-inprogress ⏳
Pull request is in progress. No review needed at this stage.
and removed
A4-gotissues 💥
Pull request is reviewed and has significant issues which must be addressed.
labels
Dec 21, 2017
Also, could you please update method signature comments, e.g. |
NikVolf
added
A0-pleasereview 🤓
Pull request needs code review.
and removed
A3-inprogress ⏳
Pull request is in progress. No review needed at this stage.
labels
Dec 21, 2017
pepyakin
added
A8-looksgood 🦄
Pull request is reviewed well.
and removed
A0-pleasereview 🤓
Pull request needs code review.
labels
Dec 22, 2017
pepyakin
approved these changes
Dec 22, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.