Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

CI: Fix cargo cache #7968

Merged
merged 2 commits into from
Mar 1, 2018
Merged

CI: Fix cargo cache #7968

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ef58698
Fix cache
General-Beck Feb 21, 2018
1f0c0c5
Only clean locked cargo cache on windows
Mar 1, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions scripts/gitlab-build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,8 @@ set_env_win () {
echo "@ signtool sign /f "\%"1 /p "\%"2 /tr http://timestamp.comodoca.com /du https://parity.io "\%"3" > sign.cmd
}
build () {
echo "Remove index"
rm -rf cargo/registry/index/*.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess you meant, .cargo/registry/index? That's a terrible idea! Cargo will have to redownload it's crates index and cargo builds may interfere with each.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cargo cache is in cargo/ #7921: https://github.com/paritytech/parity/pull/7921/files

The path "is correct", but I can't evaluate if this is the correct way to address this. Problem is that windows builds fail due to a build lock even though there is no other build running.

https://gitlab.parity.io/parity/parity/-/jobs/80511

Please advise :)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@General-Beck Let's wrap this in the conditional if [[ "windows" = $IDENT ]] for now?
I guess the actual root cause is our cache key selection, but I would do that as a part of enhancing the #7988

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@5chdn I believe this is not a correct way of addressing the problem

echo "Build parity:"
cargo build --target $PLATFORM --features final --release
echo "Build evmbin:"
Expand Down