This repository has been archived by the owner on Feb 2, 2021. It is now read-only.
Add cookie_root_domain to system dashboard #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The env var for cookie_root_domain was missing from the system_dashboard deployment, this meant when users with OAuth enabled did not get their token removed when clicking logout. see openfaas/openfaas-cloud#623 see openfaas/openfaas-cloud#624 This was tested by updating an existing deployment with the new setting and logging out, the cookie was removed and the oauth flow was triggered to gain a new token Signed-off-by: Alistair Hey <[email protected]>
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The env var for cookie_root_domain was missing from the system_dashboard
deployment, this meant when users with OAuth enabled did not get their
token removed when clicking logout.
see openfaas/openfaas-cloud#623
see openfaas/openfaas-cloud#624
Signed-off-by: Alistair Hey [email protected]
How Has This Been Tested?
This was tested by updating an existing deployment with the new setting
and logging out, the cookie was removed and the oauth flow was triggered
to gain a new token
Checklist:
I have:
git commit -s