Skip to content
This repository has been archived by the owner on Mar 10, 2023. It is now read-only.

Add Cookie root domain env variable to Dashboard #633

Merged
merged 1 commit into from
May 11, 2020
Merged

Add Cookie root domain env variable to Dashboard #633

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dashboard/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ Set `public_url` to be the URL for the IP / DNS of the OpenFaaS Cloud.

Set `cookie_root_domain` when using auth.

Example with domain `o6s.io`:
Example with domain `.system.o6s.io`:

```
cookie_root_domain: ".system.o6s.io"
Expand Down
4 changes: 3 additions & 1 deletion dashboard/dashboard_config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,4 +9,6 @@ environment:
# Comment out if not using public pretty-URL
pretty_url: https://user.o6s.io/function
# Comment out if not using public pretty-URL
query_pretty_url: 'true'
query_pretty_url: 'true'
# Cookie root domain, set is using OAuth, used to remove a user's cookie
cookie_root_domain: 'system.o6s.io'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is templated, so wouldn't this need to be changed in ofc-bootstrap rather than here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be synced here -> https://github.com/openfaas-incubator/ofc-bootstrap/blob/master/templates/dashboard_config.yml

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeh, it will need changing there. The ones in that yaml looked like "example" settings so I added there for future reference.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

openfaas/ofc-bootstrap#206