Bugfix/#64: Replace old implementation to check empty regions with contrib module… #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ttachments alter hook
…ass Framework update
…ic `(s)css` rules
… `(s)css` rules
…c `(s)css` rules
…c `(s)css` rules
…stic `(s)css` rules
…ral and stylistic `(s)css` rules
…ylistic `(s)css` rules
…tic `(s)css` rules
…nd stylistic `(s)css` rules
…ylistic `(s)css` rules
…e Sass Framework update - Alignment classes - Float clearing - Invisible content & Screenreaders
…-styling` assets library
# Conflicts: # css/theme/theme--kiso.css # kiso.libraries.yml # scss/config/_variable-overrides.scss # scss/theme/elements/_headings.scss
# [*] fonts/font-awesome/fa-brands-400.ttf # [*] fonts/font-awesome/fa-brands-400.woff2 # [*] fonts/font-awesome/fa-regular-400.ttf # [*] fonts/font-awesome/fa-regular-400.woff2 # [*] fonts/font-awesome/fa-solid-900.ttf # [*] fonts/font-awesome/fa-solid-900.woff2 # [*] fonts/font-awesome/fa-regular-400.ttf # [*] fonts/font-awesome/font-awesome.css # [+] fonts/font-awesome/fa-v4compatibility.ttf # [+] fonts/font-awesome/fa-v4compatibility.woff2 # [-] fonts/font-awesome/fa-brands-400.eot # [-] fonts/font-awesome/fa-brands-400.svg # [-] fonts/font-awesome/fa-brands-400.woff # [-] fonts/font-awesome/fa-regular-400.eot # [-] fonts/font-awesome/fa-regular-400.svg # [-] fonts/font-awesome/fa-regular-400.woff # [-] fonts/font-awesome/fa-solid-900.eot # [-] fonts/font-awesome/fa-solid-900.svg # [-] fonts/font-awesome/fa-solid-900.woff
…ral rules from stylistic rules for the stylesheets (Baseline)
… "Twig Real Content"
smillart
requested changes
Jul 4, 2024
There was a problem hiding this comment.
Hey @jclemmenb4y,
Your changes should be re-based on the 3.0.x (default) branch. The 3.1.x branch is a "beta" candidate for a "possible" new future release of Kiso with Openfed Next.
| @@ -89,7 +85,7 @@ | |||
| {{ page.breadcrumb }} | |||
| {% endblock %} | |||
|
|
|||
| {% if has_navigation or has_complementary %} | |||
| {% if page.navigation|render is real_content %} | |||
There was a problem hiding this comment.
Missing test if complementary region is empty:
{% if page.navigation|render is real_content or page.complementary|render is real_content %}
smillart
changed the title
smillart
changed the title
smillart
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request relates to BOSA_0100-358 (JIRA issue) and replaces old implementation to check empty regions with contrib module "Twig Real Content".
Module "Twig Real Content" should also be added in OpenFed as declaring in Kiso's dependencies currently doesn't trigger the installation and doesn't enable the module (see https://www.drupal.org/node/2937955).
Function "has_region" declared in file "preprocess.utils.inc" might need to be kept currently to avoid issue with custom themes that override page.html.twig. What do you think @smillart ?