🐛(lib-video) thumbnail not reset on the video player #2137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntoLC
force-pushed
the
issue/anthony/lib-video/thumbnail-not-reset-correctly
branch
from
326aa81 to
b6869e7
Compare
kernicPanel
reviewed
Mar 14, 2023
src/frontend/packages/lib_video/src/components/common/VideoPlayer/index.tsx
Outdated
Show resolved
Hide resolved
kernicPanel
approved these changes
Mar 15, 2023
lunika
reviewed
Mar 15, 2023
| @@ -14,7 +14,9 @@ import { | |||
| } from 'lib-components'; | |||
| import { render } from 'lib-tests'; | |||
| import React from 'react'; | |||
| import { act } from 'react-dom/test-utils'; | |||
There was a problem hiding this comment.
should not we use the one from react testing library ?
AntoLC
force-pushed
the
issue/anthony/lib-video/thumbnail-not-reset-correctly
branch
from
0b35c15 to
d6443b7
Compare
lunika
approved these changes
Mar 16, 2023
When we removed the thumbnail in the VOD dashboard, the thumbnail of the player was not correctly updated. This commit fixes this issue.
When we removed a thumbnail, a memory leak was created with the confirmation modal. This modal was not unmounted correctly.
AntoLC
force-pushed
the
issue/anthony/lib-video/thumbnail-not-reset-correctly
branch
from
d6443b7 to
9887b93
Compare
AntoLC
deleted the
issue/anthony/lib-video/thumbnail-not-reset-correctly
branch
lunika
added a commit
that referenced
this pull request
Apr 19, 2023
Added - standalone website: - Integrate VOD dashboard (#2086) - List the lives in the contents section (#2104) - Live session model - Livesession backend rewrite - Add sentry - Create a live from the website (#2134) - Integrate webinar dashboard (#2135) - Add a License Manager widget for LTI VOD view - Add a title to the classroom file dropzone - Add can_edit property on a serialized video - Add an attribute to consumer site to deactivate resources in LTI select - live transpilation on lib-video (#2150) - live transpilation on lib-classroom (#2157) - live transpilation on lib-markdown (#2160) - live transpilation on lib-components (#2161) - live transpilation on lib-tests (#2163) - live transpilation on lib-common (#2164) - Add a widget provider for the classroom creation form - Allow delete playlist resources - FileDepository - Classroom - Document - Markdown - Allow delete playlist - add routes related URL: - thumbnails - timed_text_track - shared_live_media - Add classroom widgets : - InfoBar - Description - Scheduling - Invite links - Support sharing - Recordings - Add classroom invite link for an instructor - Add a "Tools & Applications" widget for classrooms Changed - Update live sessions API to use nested video ID route - Move generic widget components from lib-video to lib-components - Make video dashboard collapsed by default - improve the dropdown languages positionning in the dashboard (#2138) - Make video dashboard visible by default, and collapsed when using the Moodle atto plugin - Update live_session api to use mixin to prevent url crafting - standalone website: - put the creating ressource form submit button disabled when the form is invalid (#2175) Fixed - redirect to error page when VOD is deleted - Manage disconnection when multiple tabs were open on standalone site - synchronisation between pages for the VOD description widget - tooltip position on the website context dashboard (#2136) - thumbnail not reset correctly on the video player (#2137) - display title / description when a classroom is not scheduled and not started - correctly fetch transcript content in TranscriptReader - remove unused 'initiate-live' permissions - increase debounce time in classroom description widget - remove id3 tags upload when live channel is not ready - add an invitation link for moderators in a launched classroom if available
lunika
added a commit
that referenced
this pull request
Apr 19, 2023
Added - standalone website: - Integrate VOD dashboard (#2086) - List the lives in the contents section (#2104) - Live session model - Livesession backend rewrite - Add sentry - Create a live from the website (#2134) - Integrate webinar dashboard (#2135) - Add a License Manager widget for LTI VOD view - Add a title to the classroom file dropzone - Add can_edit property on a serialized video - Add an attribute to consumer site to deactivate resources in LTI select - live transpilation on lib-video (#2150) - live transpilation on lib-classroom (#2157) - live transpilation on lib-markdown (#2160) - live transpilation on lib-components (#2161) - live transpilation on lib-tests (#2163) - live transpilation on lib-common (#2164) - Add a widget provider for the classroom creation form - Allow delete playlist resources - FileDepository - Classroom - Document - Markdown - Allow delete playlist - add routes related URL: - thumbnails - timed_text_track - shared_live_media - Add classroom widgets : - InfoBar - Description - Scheduling - Invite links - Support sharing - Recordings - Add classroom invite link for an instructor - Add a "Tools & Applications" widget for classrooms Changed - Update live sessions API to use nested video ID route - Move generic widget components from lib-video to lib-components - Make video dashboard collapsed by default - improve the dropdown languages positionning in the dashboard (#2138) - Make video dashboard visible by default, and collapsed when using the Moodle atto plugin - Update live_session api to use mixin to prevent url crafting - standalone website: - put the creating ressource form submit button disabled when the form is invalid (#2175) Fixed - redirect to error page when VOD is deleted - Manage disconnection when multiple tabs were open on standalone site - synchronisation between pages for the VOD description widget - tooltip position on the website context dashboard (#2136) - thumbnail not reset correctly on the video player (#2137) - display title / description when a classroom is not scheduled and not started - correctly fetch transcript content in TranscriptReader - remove unused 'initiate-live' permissions - increase debounce time in classroom description widget - remove id3 tags upload when live channel is not ready - add an invitation link for moderators in a launched classroom if available
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fixed issue #2131
When we remove the thumbnail in the VOD dashboard, the thumbnail of the player is not correctly updated.
Proposal