Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notify hook does not handle press-level email subjects #3694

Closed
joemull opened this issue Sep 13, 2023 · 0 comments · Fixed by #3713
Closed

Notify hook does not handle press-level email subjects #3694

joemull opened this issue Sep 13, 2023 · 0 comments · Fixed by #3713
Assignees
@joemull
Labels
bug Something's not working

Comments

@joemull
Copy link
Member

joemull commented Sep 13, 2023

Describe the bug
The notify_hook function that dynamically pulls email subjects from settings only works for journal-level emails:

https://github.com/BirkbeckCTP/janeway/blob/84d141b9165ca564f02e90641e476bd0da744c94/src/utils/notify_plugins/notify_email.py#L125-L127

Janeway version
84d141b
@joemull joemull added the bug Something's not working label Sep 13, 2023
@joemull joemull added this to v1.5.2 Sep 13, 2023
joemull added a commit that referenced this issue Sep 13, 2023
@joemull
Retrieve press-level email subjects from settings #3694
2f68c5d
@joemull joemull mentioned this issue Sep 13, 2023
Merged
@joemull joemull moved this to PR Submitted in v1.5.2 Sep 13, 2023
@joemull joemull self-assigned this Sep 13, 2023
joemull added a commit that referenced this issue Sep 13, 2023
@joemull
Add an f to the f-string #3694
19bd80f
joemull added a commit that referenced this issue Dec 6, 2023
@joemull
Remove press-level override of subject string in core logic #3694
39e2b8e
mauromsl added a commit that referenced this issue Jan 25, 2024
@mauromsl
Merge pull request #3713 from BirkbeckCTP/3694-notify-email-subject-p…
556598b 
…ress

Retrieve press-level email subjects from settings #3694
@github-project-automation github-project-automation bot moved this from PR Submitted to Done in v1.5.2 Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joemull joemull

Labels
bug Something's not working
Projects
No open projects
v1.5.2
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Retrieve press-level email subjects from settings #3694 openlibhums/janeway
1 participant
@joemull