Retrieve press-level email subjects from settings #3694 #3713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajrbyers
requested changes
Sep 15, 2023
There was a problem hiding this comment.
This is a great step in the right direction. I just had a quick look at the logic for some of the emails that send at the press level as well as the journal (Password Reset and Registration Confirmation) at the moment when no request.journal is present these send a hard-coded subject see:
The two functions in core.logic need a little tweak to make this PR complete.
ajrbyers
approved these changes
Jan 16, 2024
mauromsl
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3694.