Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat) Added translations for zh and zh_CN #1582

Merged
merged 24 commits into from
Jan 15, 2024
Merged

Conversation

befantasy
Copy link
Contributor

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

Screenshots

Related Issue

Other

@vasharma05 vasharma05 merged commit 6bac380 into openmrs:main Jan 15, 2024
6 checks passed
@vasharma05 vasharma05 changed the title Updat the translation for zh and zh_CN Update the translation for zh and zh_CN Jan 15, 2024
@vasharma05 vasharma05 changed the title Update the translation for zh and zh_CN (feat) Added translations for zh and zh_CN Jan 15, 2024
@denniskigen
Copy link
Member

Hey, @befantasy, it looks like this work is still ongoing. Is that right?

@befantasy
Copy link
Contributor Author

Hey, @befantasy, it looks like this work is still ongoing. Is that right?

Yes, for some short words or strings, I need to combine UI and context to understand their true meaning. I am not familiar with node.js/react at all, and I haven't figured out how to visualize and edit front-end code in a WYSIWYG manner to locate the position of the strings in the UI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants