(chore) Separate linting and formatting concerns #1774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denniskigen
requested review from
ibacher,
vasharma05,
hadijahkyampeire and
samuelmale
|
Size Change: +134 B (0%) Total Size: 11 MB ℹ️ View Unchanged
|
denniskigen
force-pushed
the
chore/remove-eslint-plugin-prettier
branch
from
a0cbf9b to
a4c9cf2
Compare
ibacher
approved these changes
Apr 3, 2024
denniskigen
changed the title
denniskigen
added a commit
to openmrs/openmrs-esm-cohortbuilder-app
that referenced
this pull request
Dec 4, 2024
This commit includes the following changes to the tooling used in this project: - Update ESLint config with `import` and `react-hooks` plugins - Add turborepo for build caching and script parallelization - Align TypeScript and Jest configs with OpenMRS standards - Separate linting from formatting scripts so they can be run separately as described in [similar PRs](openmrs/openmrs-esm-patient-chart#1774) for other OpenMRS frontend modules - Update Yarn to latest stable version - Remove redundant Webpack `scriptRuleConfig` override This aligns our tooling configuration with other OpenMRS frontend modules, improving consistency across the ecosystem.
denniskigen
added a commit
to openmrs/openmrs-esm-cohortbuilder-app
that referenced
this pull request
Dec 4, 2024
This commit includes the following changes to the tooling used in this project: - Update ESLint config with `import` and `react-hooks` plugins - Add turborepo for build caching and script parallelization - Align TypeScript and Jest configs with OpenMRS standards - Separate linting from formatting scripts so they can be run separately as described in [similar PRs](openmrs/openmrs-esm-patient-chart#1774) for other OpenMRS frontend modules - Update Yarn to latest stable version - Remove redundant Webpack `scriptRuleConfig` override This aligns our tooling configuration with other OpenMRS frontend modules, improving consistency across the ecosystem.
denniskigen
added a commit
to openmrs/openmrs-esm-cohortbuilder-app
that referenced
this pull request
Dec 6, 2024
* (chore) Various tooling tweaks This commit includes the following changes to the tooling used in this project: - Update ESLint config with `import` and `react-hooks` plugins - Add turborepo for build caching and script parallelization - Align TypeScript and Jest configs with OpenMRS standards - Separate linting from formatting scripts so they can be run separately as described in [similar PRs](openmrs/openmrs-esm-patient-chart#1774) for other OpenMRS frontend modules - Update Yarn to latest stable version - Remove redundant Webpack `scriptRuleConfig` override This aligns our tooling configuration with other OpenMRS frontend modules, improving consistency across the ecosystem. * Prettier * Fixup * Review feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
Our current setup is running Prettier as a part of ESLint. These are two separate concerns that should be handled separately by different tools.
This PR removes eslint-plugin-prettier and eslint-config-prettier from our linting config as recommended here and here. I've also separated ESLint concerns from Prettier so that ESLint doesn't handle both. The recommended modern approach treats Prettier and ESLint as separate unrelated tools.
I've also moved the
prettierscript from the root-level package.json to thelint-stagedconfig so thatlint-stagedruns Prettier after ESLint.Screenshots
Related Issue
Other