Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(chore) Separate linting and formatting concerns #1774

Merged
merged 1 commit into from
Apr 3, 2024
Merged

(chore) Separate linting and formatting concerns #1774

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .eslintrc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"env": {
"node": true
},
"extends": ["eslint:recommended", "plugin:prettier/recommended", "plugin:@typescript-eslint/recommended", "prettier"],
"extends": ["eslint:recommended", "plugin:@typescript-eslint/recommended"],
"parser": "@typescript-eslint/parser",
"plugins": ["@typescript-eslint"],
"rules": {
Expand Down
2 changes: 1 addition & 1 deletion .husky/pre-commit
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,5 @@

set -e # die on error

yarn prettier && npx lint-staged
npx lint-staged
yarn turbo run extract-translations
9 changes: 4 additions & 5 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@
"ci:bump-form-engine-lib": "yarn up @openmrs/openmrs-form-engine-lib@next",
"release": "yarn workspaces foreach --all --topological version",
"verify": "turbo lint typescript test --color --concurrency=5",
"prettier": "prettier --config prettier.config.js --write \"packages/**/*.{ts,tsx,css,scss}\" \"e2e/**/*.ts\" --list-different",
"postinstall": "husky install",
"test-e2e": "playwright test"
},
Expand Down Expand Up @@ -41,10 +40,7 @@
"dayjs": "^1.11.10",
"dotenv": "^16.3.1",
"eslint": "^8.50.0",
"eslint-config-prettier": "^9.0.0",
"eslint-config-ts-react-important-stuff": "^3.0.0",
"eslint-plugin-playwright": "^0.16.0",
"eslint-plugin-prettier": "^5.0.0",
"husky": "^8.0.3",
"i18next": "^21.10.0",
"i18next-parser": "^6.6.0",
Expand All @@ -70,7 +66,10 @@
"webpack-dev-server": "^4.15.1"
},
"lint-staged": {
"*.{js,jsx,ts,tsx}": "eslint --cache --fix"
"*.{js,jsx,ts,tsx}": [
"eslint --cache --fix",
"prettier --cache --write --ignore-unknown --list-different"
]
},
"resolutions": {
"sass": "^1.54.3"
Expand Down
Loading
Loading