-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(feat) O3 3128: Add extension slots to lab and drug order forms #1818
Conversation
Size Change: +84 B (0%) Total Size: 11.7 MB ℹ️ View Unchanged
|
Am not quite experienced in this yet. Will let others to provide their reviews. The idea is to provide a section where details about a drug or lab test i.e. availability and cost can be displayed. This will help avoid back and forth between clinicians and the lab/pharmacy as they can only order based on availability and/or affordability |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Just a couple of questions about an import and styling.
@@ -3,7 +3,7 @@ import classNames from 'classnames'; | |||
import { useTranslation } from 'react-i18next'; | |||
import { Button, ButtonSkeleton, Search, SkeletonText, Tile } from '@carbon/react'; | |||
import { ArrowRight, ShoppingCartArrowDown, ShoppingCartArrowUp } from '@carbon/react/icons'; | |||
import { useDebounce, useLayoutType, useSession, ResponsiveWrapper } from '@openmrs/esm-framework'; | |||
import { useDebounce, useLayoutType, useSession, ResponsiveWrapper, ExtensionSlot } from '@openmrs/esm-framework'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn’t look like this import is used anywhere.
packages/esm-patient-labs-app/src/lab-orders/add-lab-order/lab-order-form.scss
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly LGTM, except for a concern about some CSS being applied to an extension slot.
…mrs#1818) * (feat) Add slots to labs and drug form * O3-3128 (feat) Enhance lab, orders and dispensing form with addition slot * Fixup --------- Co-authored-by: Dennis Kigen <[email protected]>
* (feat) O3-3156: Submitting the start visit form should mutate appointments (#1825) * (fix) O3-2852: Fix the viewport size of the Start Visit form on tablet (#1765) * Overlapping issue fixed in visit-form * Make viewport height responsive - different values for desktop and tablet --------- Co-authored-by: Mutesasira Moses <[email protected]> Co-authored-by: Dennis Kigen <[email protected]> * (refactor) O3-2626: Reuse useAllowedFileExtensions hook from Common Lib (#1827) (refactor) Reuse allowedFileExtensions hook from Common Lib * (feat) O3-3158: Conditionally render Patient Header in the Start Visit form (#1823) * (feat) O3-3158: Visit Form should support (optionally) rendering Patient Header * (feat) O3-3158: Visit Form should support (optionally) rendering Patient Header --------- Co-authored-by: Dennis Kigen <[email protected]> * (chore) Bump form-engine lib (#1828) Bump form-engine lib * (chore) Bump form-engine lib (#1829) Bump form-engine lib * (fix) Widen range to detect "current" data entry * (fix) O3-3158: Follow-up commit fixing patientUuid sometimes undefined (#1831) * (feat) O3 3128: Add extension slots to lab and drug order forms (#1818) * (feat) Add slots to labs and drug form * O3-3128 (feat) Enhance lab, orders and dispensing form with addition slot * Fixup --------- Co-authored-by: Dennis Kigen <[email protected]> * (chore) Bump RFE version (#1833) * Bump RFE version * Update to next * (fix) O3-3196: Fix diagnoses tags display on tablet (#1834) * (fix) O3-3195: Fix rendering logic for the weight tile (#1835) * (fix) return encounter type uuid from encounter type object (#1836) return uuid from encounter type object * (chore) Bump React form engine and yarn (#1837) * (chore) Release v8.0.0 (#1839) * (feat) O3-2430: User should be able to look up frequency in dropdown by abbreviation (#1767) Co-authored-by: Dennis Kigen <[email protected]> Co-authored-by: Ian <[email protected]> * (chore) Release v8.0.1 (#1841) Co-authored-by: Dennis Kigen <[email protected]> * (chore) Bump react and related types (#1842) * (chore) Bump react and related types * Fixup * Bump test deps to remove warnings * (fix) O3-3158: Restore abortControllers * Revert "(fix) O3-3158: Restore abortControllers" This reverts commit 0895e27. * (fix) O3-3158: Restore abortControllers (#1843) * (chore) Bump react form engine * (fix) O3-3175: Remove Breadcrumbs menu from Patient Chart (#1832) * (fix)- O3-3175 Remove Breadcrumbs * Remove translation strings * Remove more occurrences of breadcrumbs --------- Co-authored-by: Dennis Kigen <[email protected]> * (feat) Update custom representation to match required properties for encounter observation (#1845) * Make attachment upload modal span full-width * (chore) Bump react form engine (#1846) * (feat) O3-2626: Add the ability to upload multiple images in the Visit Note form (#1826) Co-authored-by: Dennis Kigen <[email protected]> * (fix) O3-3284: Display correctly formatted patient name throughout patient chart apps (#1849) * Display formatted patient name in visit-header and patient-details-tile components * Display formatted patient name in patient-banner component. * Display formatted patient name in esm-patient-labs-app * Display formatted patient name in esm-patient-medications-app * Display formatted patient name in esm-patient-orders-app * Display formatted patient name in esm-patient-vitals-app * Bump core tooling * (feat) O3-3165: Add confirmation modal when deleting repeat question (#1840) * (feat): Add confirmation modal when deleting repeat question * (refactor): register modal as extension * (refactor): change modal registration name * Bump form engine and core tooling --------- Co-authored-by: Dennis Kigen <[email protected]> --------- Co-authored-by: Mark Goodrich <[email protected]> Co-authored-by: Madhu Lokesh <[email protected]> Co-authored-by: Mutesasira Moses <[email protected]> Co-authored-by: Dennis Kigen <[email protected]> Co-authored-by: Samuel Male <[email protected]> Co-authored-by: Ian <[email protected]> Co-authored-by: Ian <[email protected]> Co-authored-by: Donald Kibet <[email protected]> Co-authored-by: Jamie Arodi <[email protected]> Co-authored-by: Thembo Jonathan <[email protected]> Co-authored-by: Piyush Mishra <[email protected]> Co-authored-by: Vineet Sharma <[email protected]> Co-authored-by: Bhargav kodali <[email protected]> Co-authored-by: jwnasambu <[email protected]> Co-authored-by: Gavin Falconer <[email protected]> Co-authored-by: Nethmi Rodrigo <[email protected]>
Requirements
Summary
see https://openmrs.atlassian.net/browse/O3-3128
Screenshots
Related Issue
Other