(feat) O3-3165: Add confirmation modal when deleting repeat question #1840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -404 kB (-3.54%) Total Size: 11 MB
ℹ️ View Unchanged
|
NethmiRodrigo
force-pushed
the
feat/delete-repeat-modal
branch
from
1f675e3 to
2e33957
Compare
3 tasks
|
The failing checks are due to the added prop |
ibacher
approved these changes
May 23, 2024
packages/esm-form-engine-app/src/form-renderer/repeat/delete-question-modal.component.tsx
Outdated
Show resolved
Hide resolved
NethmiRodrigo
force-pushed
the
feat/delete-repeat-modal
branch
from
2e33957 to
0fbeb89
Compare
ibacher
approved these changes
May 24, 2024
|
@ibacher @denniskigen I tried re-running the workflows, but they still fail with the same reason as before (the new prop not being identified). Any ideas as to why it could be still failing? |
|
@NethmiRodrigo You need to update the version of the form-engine-library... |
denniskigen
force-pushed
the
feat/delete-repeat-modal
branch
from
0fbeb89 to
833cd80
Compare
denniskigen
force-pushed
the
feat/delete-repeat-modal
branch
from
833cd80 to
890f011
Compare
denniskigen
approved these changes
May 24, 2024
alaboso
added a commit
that referenced
this pull request
May 27, 2024
* (feat) O3-3156: Submitting the start visit form should mutate appointments (#1825) * (fix) O3-2852: Fix the viewport size of the Start Visit form on tablet (#1765) * Overlapping issue fixed in visit-form * Make viewport height responsive - different values for desktop and tablet --------- Co-authored-by: Mutesasira Moses <[email protected]> Co-authored-by: Dennis Kigen <[email protected]> * (refactor) O3-2626: Reuse useAllowedFileExtensions hook from Common Lib (#1827) (refactor) Reuse allowedFileExtensions hook from Common Lib * (feat) O3-3158: Conditionally render Patient Header in the Start Visit form (#1823) * (feat) O3-3158: Visit Form should support (optionally) rendering Patient Header * (feat) O3-3158: Visit Form should support (optionally) rendering Patient Header --------- Co-authored-by: Dennis Kigen <[email protected]> * (chore) Bump form-engine lib (#1828) Bump form-engine lib * (chore) Bump form-engine lib (#1829) Bump form-engine lib * (fix) Widen range to detect "current" data entry * (fix) O3-3158: Follow-up commit fixing patientUuid sometimes undefined (#1831) * (feat) O3 3128: Add extension slots to lab and drug order forms (#1818) * (feat) Add slots to labs and drug form * O3-3128 (feat) Enhance lab, orders and dispensing form with addition slot * Fixup --------- Co-authored-by: Dennis Kigen <[email protected]> * (chore) Bump RFE version (#1833) * Bump RFE version * Update to next * (fix) O3-3196: Fix diagnoses tags display on tablet (#1834) * (fix) O3-3195: Fix rendering logic for the weight tile (#1835) * (fix) return encounter type uuid from encounter type object (#1836) return uuid from encounter type object * (chore) Bump React form engine and yarn (#1837) * (chore) Release v8.0.0 (#1839) * (feat) O3-2430: User should be able to look up frequency in dropdown by abbreviation (#1767) Co-authored-by: Dennis Kigen <[email protected]> Co-authored-by: Ian <[email protected]> * (chore) Release v8.0.1 (#1841) Co-authored-by: Dennis Kigen <[email protected]> * (chore) Bump react and related types (#1842) * (chore) Bump react and related types * Fixup * Bump test deps to remove warnings * (fix) O3-3158: Restore abortControllers * Revert "(fix) O3-3158: Restore abortControllers" This reverts commit 0895e27. * (fix) O3-3158: Restore abortControllers (#1843) * (chore) Bump react form engine * (fix) O3-3175: Remove Breadcrumbs menu from Patient Chart (#1832) * (fix)- O3-3175 Remove Breadcrumbs * Remove translation strings * Remove more occurrences of breadcrumbs --------- Co-authored-by: Dennis Kigen <[email protected]> * (feat) Update custom representation to match required properties for encounter observation (#1845) * Make attachment upload modal span full-width * (chore) Bump react form engine (#1846) * (feat) O3-2626: Add the ability to upload multiple images in the Visit Note form (#1826) Co-authored-by: Dennis Kigen <[email protected]> * (fix) O3-3284: Display correctly formatted patient name throughout patient chart apps (#1849) * Display formatted patient name in visit-header and patient-details-tile components * Display formatted patient name in patient-banner component. * Display formatted patient name in esm-patient-labs-app * Display formatted patient name in esm-patient-medications-app * Display formatted patient name in esm-patient-orders-app * Display formatted patient name in esm-patient-vitals-app * Bump core tooling * (feat) O3-3165: Add confirmation modal when deleting repeat question (#1840) * (feat): Add confirmation modal when deleting repeat question * (refactor): register modal as extension * (refactor): change modal registration name * Bump form engine and core tooling --------- Co-authored-by: Dennis Kigen <[email protected]> --------- Co-authored-by: Mark Goodrich <[email protected]> Co-authored-by: Madhu Lokesh <[email protected]> Co-authored-by: Mutesasira Moses <[email protected]> Co-authored-by: Dennis Kigen <[email protected]> Co-authored-by: Samuel Male <[email protected]> Co-authored-by: Ian <[email protected]> Co-authored-by: Ian <[email protected]> Co-authored-by: Donald Kibet <[email protected]> Co-authored-by: Jamie Arodi <[email protected]> Co-authored-by: Thembo Jonathan <[email protected]> Co-authored-by: Piyush Mishra <[email protected]> Co-authored-by: Vineet Sharma <[email protected]> Co-authored-by: Bhargav kodali <[email protected]> Co-authored-by: jwnasambu <[email protected]> Co-authored-by: Gavin Falconer <[email protected]> Co-authored-by: Nethmi Rodrigo <[email protected]>
arodidev
pushed a commit
to arodidev/openmrs-esm-patient-chart
that referenced
this pull request
May 28, 2024
…penmrs#1840) * (feat): Add confirmation modal when deleting repeat question * (refactor): register modal as extension * (refactor): change modal registration name * Bump form engine and core tooling --------- Co-authored-by: Dennis Kigen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
This PR implements and registers the confirmation modal that gets triggered whenever a user attempts to delete a
repeatrendering obsGroup question.routes.jsonin themodalssection.FormEngineas a prop.Screenshots
Related Issue
https://openmrs.atlassian.net/browse/O3-3165
Other
Related PR
Is dependant on the above related PR.