-
Notifications
You must be signed in to change notification settings - Fork 254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filter by encounter types implemented in observation endpoint on esm-generic-patient-widgets-app #827
Conversation
…generic-patient-widgets-app
Size Change: 0 B Total Size: 5.54 MB ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@icrc-agomes Could you look into the failing tests. Likely we need to update a mock somewhere to ensure encounterTypes
is always an empty array.
…pp-filter-by-encounter-types
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @icrc-agomes! Couple of small things.
encounterTypes: Array<{ | ||
encounterType: string; | ||
}>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
encounterTypes: Array<{ | |
encounterType: string; | |
}>; | |
encounterTypes: Array<string>; |
showGraphByDefault: { | ||
_type: Type.Boolean, | ||
_description: 'Displayed graph by default', | ||
_default: true, | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if this should be added as part of this PR?
…pp-filter-by-encounter-types
…pp-filter-by-encounter-types
…pp-filter-by-encounter-types
@icrc-agomes can we close/cancel this PR if #854 is now the desired source of truth? |
Requirements
Summary
In esm-generic-patient-widgets-app it was needed to implement the filter of observations endpoint by encounter type