Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter by encounter types implemented in observation endpoint on esm-generic-patient-widgets-app #827

Conversation

icrc-agomes
Copy link
Contributor

Requirements

  • This PR has a title that briefly describes the work done, including the ticket number if there is a ticket.
  • My work conforms to the OpenMRS 3.0 Styleguide.
  • My work includes tests or is validated by existing tests.

Summary

In esm-generic-patient-widgets-app it was needed to implement the filter of observations endpoint by encounter type

Sorry, something went wrong.

…generic-patient-widgets-app
@github-actions
Copy link
Contributor

github-actions bot commented Sep 30, 2022

Size Change: 0 B

Total Size: 5.54 MB

ℹ️ View Unchanged
Filename Size
packages/esm-form-entry-app/dist/574.a78c7d55ae3ded7efd21.js 123 B
packages/esm-form-entry-app/dist/689.36af8786bf1453d28975.js 30.2 kB
packages/esm-form-entry-app/dist/744.a98f0c49fe596abe9fc7.js 10.6 kB
packages/esm-form-entry-app/dist/openmrs-esm-form-entry-app.js 404 kB
packages/esm-generic-patient-widgets-app/dist/150.js 867 B
packages/esm-generic-patient-widgets-app/dist/206.js 11.2 kB
packages/esm-generic-patient-widgets-app/dist/308.js 142 kB
packages/esm-generic-patient-widgets-app/dist/340.js 8.83 kB
packages/esm-generic-patient-widgets-app/dist/377.js 3.35 kB
packages/esm-generic-patient-widgets-app/dist/416.js 101 kB
packages/esm-generic-patient-widgets-app/dist/574.js 188 B
packages/esm-generic-patient-widgets-app/dist/709.js 6.67 kB
packages/esm-generic-patient-widgets-app/dist/74.js 5.11 kB
packages/esm-generic-patient-widgets-app/dist/784.js 2.64 kB
packages/esm-generic-patient-widgets-app/dist/858.js 115 kB
packages/esm-generic-patient-widgets-app/dist/main.js 3.36 kB
packages/esm-generic-patient-widgets-app/dist/openmrs-esm-generic-patient-widgets-app.js 3.33 kB
packages/esm-patient-allergies-app/dist/0.js 2.48 kB
packages/esm-patient-allergies-app/dist/134.js 8.38 kB
packages/esm-patient-allergies-app/dist/142.js 5.45 kB
packages/esm-patient-allergies-app/dist/206.js 11.2 kB
packages/esm-patient-allergies-app/dist/26.js 3.27 kB
packages/esm-patient-allergies-app/dist/340.js 8.82 kB
packages/esm-patient-allergies-app/dist/435.js 1.22 kB
packages/esm-patient-allergies-app/dist/574.js 674 B
packages/esm-patient-allergies-app/dist/628.js 134 kB
packages/esm-patient-allergies-app/dist/709.js 6.66 kB
packages/esm-patient-allergies-app/dist/735.js 2.31 kB
packages/esm-patient-allergies-app/dist/757.js 130 B
packages/esm-patient-allergies-app/dist/775.js 3.81 kB
packages/esm-patient-allergies-app/dist/784.js 2.63 kB
packages/esm-patient-allergies-app/dist/841.js 3.42 kB
packages/esm-patient-allergies-app/dist/858.js 115 kB
packages/esm-patient-allergies-app/dist/879.js 2.88 kB
packages/esm-patient-allergies-app/dist/main.js 3.37 kB
packages/esm-patient-allergies-app/dist/openmrs-esm-patient-allergies-app.js 3.36 kB
packages/esm-patient-appointments-app/dist/206.js 11.2 kB
packages/esm-patient-appointments-app/dist/277.js 4.16 kB
packages/esm-patient-appointments-app/dist/327.js 8.23 kB
packages/esm-patient-appointments-app/dist/340.js 8.82 kB
packages/esm-patient-appointments-app/dist/358.js 221 B
packages/esm-patient-appointments-app/dist/574.js 508 B
packages/esm-patient-appointments-app/dist/709.js 6.66 kB
packages/esm-patient-appointments-app/dist/757.js 131 B
packages/esm-patient-appointments-app/dist/76.js 797 B
packages/esm-patient-appointments-app/dist/784.js 2.63 kB
packages/esm-patient-appointments-app/dist/794.js 3.77 kB
packages/esm-patient-appointments-app/dist/858.js 115 kB
packages/esm-patient-appointments-app/dist/879.js 2.88 kB
packages/esm-patient-appointments-app/dist/916.js 221 B
packages/esm-patient-appointments-app/dist/956.js 124 kB
packages/esm-patient-appointments-app/dist/main.js 3.35 kB
packages/esm-patient-appointments-app/dist/openmrs-esm-patient-appointments-app.js 3.36 kB
packages/esm-patient-attachments-app/dist/206.js 11.2 kB
packages/esm-patient-attachments-app/dist/340.js 8.82 kB
packages/esm-patient-attachments-app/dist/398.js 132 B
packages/esm-patient-attachments-app/dist/488.js 1.1 kB
packages/esm-patient-attachments-app/dist/492.js 6.07 kB
packages/esm-patient-attachments-app/dist/525.js 796 B
packages/esm-patient-attachments-app/dist/552.js 917 B
packages/esm-patient-attachments-app/dist/574.js 679 B
packages/esm-patient-attachments-app/dist/709.js 6.66 kB
packages/esm-patient-attachments-app/dist/739.js 6.44 kB
packages/esm-patient-attachments-app/dist/752.js 589 B
packages/esm-patient-attachments-app/dist/757.js 6.5 kB
packages/esm-patient-attachments-app/dist/784.js 2.63 kB
packages/esm-patient-attachments-app/dist/813.js 14.8 kB
packages/esm-patient-attachments-app/dist/841.js 99 kB
packages/esm-patient-attachments-app/dist/858.js 115 kB
packages/esm-patient-attachments-app/dist/937.js 2.54 kB
packages/esm-patient-attachments-app/dist/96.js 7.71 kB
packages/esm-patient-attachments-app/dist/main.js 3.32 kB
packages/esm-patient-attachments-app/dist/openmrs-esm-patient-attachments-app.js 3.33 kB
packages/esm-patient-banner-app/dist/150.js 862 B
packages/esm-patient-banner-app/dist/206.js 11.2 kB
packages/esm-patient-banner-app/dist/293.js 20.9 kB
packages/esm-patient-banner-app/dist/303.js 4.45 kB
packages/esm-patient-banner-app/dist/322.js 1.4 kB
packages/esm-patient-banner-app/dist/340.js 8.81 kB
packages/esm-patient-banner-app/dist/524.js 931 B
packages/esm-patient-banner-app/dist/574.js 267 B
packages/esm-patient-banner-app/dist/709.js 6.66 kB
packages/esm-patient-banner-app/dist/757.js 128 B
packages/esm-patient-banner-app/dist/784.js 2.63 kB
packages/esm-patient-banner-app/dist/858.js 115 kB
packages/esm-patient-banner-app/dist/869.js 1.42 kB
packages/esm-patient-banner-app/dist/88.js 5.14 kB
packages/esm-patient-banner-app/dist/998.js 8.07 kB
packages/esm-patient-banner-app/dist/main.js 3.32 kB
packages/esm-patient-banner-app/dist/openmrs-esm-patient-banner-app.js 3.32 kB
packages/esm-patient-biometrics-app/dist/107.js 355 B
packages/esm-patient-biometrics-app/dist/197.js 1.08 kB
packages/esm-patient-biometrics-app/dist/206.js 11.2 kB
packages/esm-patient-biometrics-app/dist/210.js 95.9 kB
packages/esm-patient-biometrics-app/dist/285.js 2.34 kB
packages/esm-patient-biometrics-app/dist/308.js 142 kB
packages/esm-patient-biometrics-app/dist/340.js 8.82 kB
packages/esm-patient-biometrics-app/dist/377.js 3.34 kB
packages/esm-patient-biometrics-app/dist/574.js 130 B
packages/esm-patient-biometrics-app/dist/709.js 6.66 kB
packages/esm-patient-biometrics-app/dist/713.js 5.44 kB
packages/esm-patient-biometrics-app/dist/757.js 130 B
packages/esm-patient-biometrics-app/dist/758.js 355 B
packages/esm-patient-biometrics-app/dist/784.js 2.63 kB
packages/esm-patient-biometrics-app/dist/858.js 115 kB
packages/esm-patient-biometrics-app/dist/879.js 2.88 kB
packages/esm-patient-biometrics-app/dist/892.js 5.98 kB
packages/esm-patient-biometrics-app/dist/main.js 3.38 kB
packages/esm-patient-biometrics-app/dist/openmrs-esm-patient-biometrics-app.js 3.37 kB
packages/esm-patient-chart-app/dist/124.js 2.5 kB
packages/esm-patient-chart-app/dist/153.js 426 B
packages/esm-patient-chart-app/dist/2.js 412 B
packages/esm-patient-chart-app/dist/202.js 1.37 kB
packages/esm-patient-chart-app/dist/203.js 1.13 kB
packages/esm-patient-chart-app/dist/220.js 4.9 kB
packages/esm-patient-chart-app/dist/244.js 469 B
packages/esm-patient-chart-app/dist/260.js 3 kB
packages/esm-patient-chart-app/dist/274.js 2.38 kB
packages/esm-patient-chart-app/dist/290.js 5.89 kB
packages/esm-patient-chart-app/dist/331.js 2.47 kB
packages/esm-patient-chart-app/dist/340.js 8.81 kB
packages/esm-patient-chart-app/dist/35.js 3.27 kB
packages/esm-patient-chart-app/dist/353.js 10.5 kB
packages/esm-patient-chart-app/dist/379.js 6.37 kB
packages/esm-patient-chart-app/dist/443.js 1.15 kB
packages/esm-patient-chart-app/dist/469.js 467 B
packages/esm-patient-chart-app/dist/47.js 2.47 kB
packages/esm-patient-chart-app/dist/485.js 478 B
packages/esm-patient-chart-app/dist/508.js 2.32 kB
packages/esm-patient-chart-app/dist/522.js 465 B
packages/esm-patient-chart-app/dist/551.js 187 kB
packages/esm-patient-chart-app/dist/574.js 3.08 kB
packages/esm-patient-chart-app/dist/577.js 3.57 kB
packages/esm-patient-chart-app/dist/579.js 2.5 kB
packages/esm-patient-chart-app/dist/628.js 4.16 kB
packages/esm-patient-chart-app/dist/631.js 2.53 kB
packages/esm-patient-chart-app/dist/658.js 948 B
packages/esm-patient-chart-app/dist/665.js 4.32 kB
packages/esm-patient-chart-app/dist/708.js 3.68 kB
packages/esm-patient-chart-app/dist/757.js 127 B
packages/esm-patient-chart-app/dist/784.js 2.63 kB
packages/esm-patient-chart-app/dist/828.js 1.6 kB
packages/esm-patient-chart-app/dist/843.js 6.71 kB
packages/esm-patient-chart-app/dist/857.js 4.25 kB
packages/esm-patient-chart-app/dist/858.js 115 kB
packages/esm-patient-chart-app/dist/879.js 2.88 kB
packages/esm-patient-chart-app/dist/892.js 12.6 kB
packages/esm-patient-chart-app/dist/903.js 9.31 kB
packages/esm-patient-chart-app/dist/911.js 8.43 kB
packages/esm-patient-chart-app/dist/913.js 3.15 kB
packages/esm-patient-chart-app/dist/main.js 6.29 kB
packages/esm-patient-chart-app/dist/openmrs-esm-patient-chart-app.js 3.51 kB
packages/esm-patient-conditions-app/dist/173.js 3.19 kB
packages/esm-patient-conditions-app/dist/188.js 2.42 kB
packages/esm-patient-conditions-app/dist/284.js 5.31 kB
packages/esm-patient-conditions-app/dist/340.js 8.82 kB
packages/esm-patient-conditions-app/dist/366.js 8.4 kB
packages/esm-patient-conditions-app/dist/532.js 2.38 kB
packages/esm-patient-conditions-app/dist/552.js 9.83 kB
packages/esm-patient-conditions-app/dist/574.js 375 B
packages/esm-patient-conditions-app/dist/709.js 6.66 kB
packages/esm-patient-conditions-app/dist/74.js 122 kB
packages/esm-patient-conditions-app/dist/757.js 131 B
packages/esm-patient-conditions-app/dist/76.js 823 B
packages/esm-patient-conditions-app/dist/784.js 2.63 kB
packages/esm-patient-conditions-app/dist/858.js 115 kB
packages/esm-patient-conditions-app/dist/879.js 2.88 kB
packages/esm-patient-conditions-app/dist/941.js 5.64 kB
packages/esm-patient-conditions-app/dist/main.js 3.37 kB
packages/esm-patient-conditions-app/dist/openmrs-esm-patient-conditions-app.js 3.38 kB
packages/esm-patient-forms-app/dist/206.js 11.2 kB
packages/esm-patient-forms-app/dist/216.js 410 B
packages/esm-patient-forms-app/dist/220.js 4.93 kB
packages/esm-patient-forms-app/dist/235.js 4.21 kB
packages/esm-patient-forms-app/dist/340.js 8.81 kB
packages/esm-patient-forms-app/dist/47.js 2.46 kB
packages/esm-patient-forms-app/dist/502.js 1.7 kB
packages/esm-patient-forms-app/dist/513.js 1.07 kB
packages/esm-patient-forms-app/dist/525.js 494 B
packages/esm-patient-forms-app/dist/574.js 470 B
packages/esm-patient-forms-app/dist/614.js 1.25 kB
packages/esm-patient-forms-app/dist/642.js 1.89 kB
packages/esm-patient-forms-app/dist/709.js 6.66 kB
packages/esm-patient-forms-app/dist/725.js 2.98 kB
packages/esm-patient-forms-app/dist/728.js 7.97 kB
packages/esm-patient-forms-app/dist/757.js 127 B
packages/esm-patient-forms-app/dist/775.js 88.2 kB
packages/esm-patient-forms-app/dist/784.js 2.63 kB
packages/esm-patient-forms-app/dist/803.js 409 B
packages/esm-patient-forms-app/dist/857.js 4.25 kB
packages/esm-patient-forms-app/dist/858.js 115 kB
packages/esm-patient-forms-app/dist/879.js 2.88 kB
packages/esm-patient-forms-app/dist/944.js 3.76 kB
packages/esm-patient-forms-app/dist/main.js 7.88 kB
packages/esm-patient-forms-app/dist/openmrs-esm-patient-forms-app.js 3.4 kB
packages/esm-patient-immunizations-app/dist/110.js 3.47 kB
packages/esm-patient-immunizations-app/dist/206.js 11.2 kB
packages/esm-patient-immunizations-app/dist/245.js 1.76 kB
packages/esm-patient-immunizations-app/dist/250.js 3.55 kB
packages/esm-patient-immunizations-app/dist/382.js 9.79 kB
packages/esm-patient-immunizations-app/dist/574.js 133 B
packages/esm-patient-immunizations-app/dist/684.js 1.24 kB
packages/esm-patient-immunizations-app/dist/709.js 6.67 kB
packages/esm-patient-immunizations-app/dist/724.js 132 kB
packages/esm-patient-immunizations-app/dist/757.js 133 B
packages/esm-patient-immunizations-app/dist/778.js 3.9 kB
packages/esm-patient-immunizations-app/dist/784.js 2.64 kB
packages/esm-patient-immunizations-app/dist/858.js 115 kB
packages/esm-patient-immunizations-app/dist/main.js 3.34 kB
packages/esm-patient-immunizations-app/dist/openmrs-esm-patient-immunizations-app.js 3.32 kB
packages/esm-patient-medications-app/dist/132.js 1.83 kB
packages/esm-patient-medications-app/dist/206.js 11.2 kB
packages/esm-patient-medications-app/dist/218.js 104 kB
packages/esm-patient-medications-app/dist/230.js 5.22 kB
packages/esm-patient-medications-app/dist/25.js 1.96 kB
packages/esm-patient-medications-app/dist/316.js 1.66 kB
packages/esm-patient-medications-app/dist/352.js 6.66 kB
packages/esm-patient-medications-app/dist/435.js 1.4 kB
packages/esm-patient-medications-app/dist/574.js 1.11 kB
packages/esm-patient-medications-app/dist/671.js 4.74 kB
packages/esm-patient-medications-app/dist/784.js 2.63 kB
packages/esm-patient-medications-app/dist/843.js 6.72 kB
packages/esm-patient-medications-app/dist/855.js 13.8 kB
packages/esm-patient-medications-app/dist/858.js 115 kB
packages/esm-patient-medications-app/dist/87.js 7.34 kB
packages/esm-patient-medications-app/dist/879.js 2.88 kB
packages/esm-patient-medications-app/dist/933.js 9.47 kB
packages/esm-patient-medications-app/dist/957.js 1.65 kB
packages/esm-patient-medications-app/dist/main.js 3.37 kB
packages/esm-patient-medications-app/dist/openmrs-esm-patient-medications-app.js 3.37 kB
packages/esm-patient-notes-app/dist/188.js 2.42 kB
packages/esm-patient-notes-app/dist/340.js 8.81 kB
packages/esm-patient-notes-app/dist/43.js 516 B
packages/esm-patient-notes-app/dist/552.js 9.82 kB
packages/esm-patient-notes-app/dist/570.js 119 kB
packages/esm-patient-notes-app/dist/574.js 642 B
packages/esm-patient-notes-app/dist/597.js 8.36 kB
packages/esm-patient-notes-app/dist/6.js 1.13 kB
packages/esm-patient-notes-app/dist/667.js 3.27 kB
packages/esm-patient-notes-app/dist/709.js 6.66 kB
packages/esm-patient-notes-app/dist/757.js 127 B
packages/esm-patient-notes-app/dist/784.js 2.63 kB
packages/esm-patient-notes-app/dist/838.js 3.27 kB
packages/esm-patient-notes-app/dist/857.js 4.25 kB
packages/esm-patient-notes-app/dist/858.js 115 kB
packages/esm-patient-notes-app/dist/879.js 2.88 kB
packages/esm-patient-notes-app/dist/90.js 6.25 kB
packages/esm-patient-notes-app/dist/929.js 1.39 kB
packages/esm-patient-notes-app/dist/main.js 3.39 kB
packages/esm-patient-notes-app/dist/openmrs-esm-patient-notes-app.js 3.38 kB
packages/esm-patient-programs-app/dist/109.js 3.26 kB
packages/esm-patient-programs-app/dist/13.js 3.73 kB
packages/esm-patient-programs-app/dist/145.js 4.73 kB
packages/esm-patient-programs-app/dist/206.js 11.2 kB
packages/esm-patient-programs-app/dist/238.js 3.32 kB
packages/esm-patient-programs-app/dist/340.js 8.81 kB
packages/esm-patient-programs-app/dist/435.js 859 B
packages/esm-patient-programs-app/dist/461.js 1.79 kB
packages/esm-patient-programs-app/dist/497.js 129 kB
packages/esm-patient-programs-app/dist/574.js 550 B
packages/esm-patient-programs-app/dist/709.js 6.66 kB
packages/esm-patient-programs-app/dist/757.js 129 B
packages/esm-patient-programs-app/dist/784.js 2.63 kB
packages/esm-patient-programs-app/dist/858.js 115 kB
packages/esm-patient-programs-app/dist/879.js 2.88 kB
packages/esm-patient-programs-app/dist/main.js 3.36 kB
packages/esm-patient-programs-app/dist/openmrs-esm-patient-programs-app.js 3.36 kB
packages/esm-patient-test-results-app/dist/0.js 8.33 kB
packages/esm-patient-test-results-app/dist/150.js 1.13 kB
packages/esm-patient-test-results-app/dist/206.js 11.2 kB
packages/esm-patient-test-results-app/dist/280.js 180 kB
packages/esm-patient-test-results-app/dist/296.js 99.8 kB
packages/esm-patient-test-results-app/dist/308.js 9.5 kB
packages/esm-patient-test-results-app/dist/425.js 2.17 kB
packages/esm-patient-test-results-app/dist/568.js 823 B
packages/esm-patient-test-results-app/dist/574.js 446 B
packages/esm-patient-test-results-app/dist/709.js 6.67 kB
packages/esm-patient-test-results-app/dist/757.js 131 B
packages/esm-patient-test-results-app/dist/770.js 3.94 kB
packages/esm-patient-test-results-app/dist/784.js 2.63 kB
packages/esm-patient-test-results-app/dist/817.js 4.29 kB
packages/esm-patient-test-results-app/dist/858.js 115 kB
packages/esm-patient-test-results-app/dist/926.js 36.4 kB
packages/esm-patient-test-results-app/dist/940.js 1.93 kB
packages/esm-patient-test-results-app/dist/97.js 5.87 kB
packages/esm-patient-test-results-app/dist/main.js 3.44 kB
packages/esm-patient-test-results-app/dist/openmrs-esm-patient-test-results-app.js 3.37 kB
packages/esm-patient-vitals-app/dist/206.js 11.2 kB
packages/esm-patient-vitals-app/dist/272.js 1.36 kB
packages/esm-patient-vitals-app/dist/291.js 143 kB
packages/esm-patient-vitals-app/dist/340.js 8.81 kB
packages/esm-patient-vitals-app/dist/377.js 3.34 kB
packages/esm-patient-vitals-app/dist/574.js 656 B
packages/esm-patient-vitals-app/dist/607.js 6.43 kB
packages/esm-patient-vitals-app/dist/630.js 352 B
packages/esm-patient-vitals-app/dist/638.js 355 B
packages/esm-patient-vitals-app/dist/65.js 7.16 kB
packages/esm-patient-vitals-app/dist/653.js 102 kB
packages/esm-patient-vitals-app/dist/709.js 6.66 kB
packages/esm-patient-vitals-app/dist/757.js 128 B
packages/esm-patient-vitals-app/dist/784.js 2.63 kB
packages/esm-patient-vitals-app/dist/858.js 115 kB
packages/esm-patient-vitals-app/dist/879.js 2.88 kB
packages/esm-patient-vitals-app/dist/892.js 5.98 kB
packages/esm-patient-vitals-app/dist/906.js 6.66 kB
packages/esm-patient-vitals-app/dist/main.js 3.39 kB
packages/esm-patient-vitals-app/dist/openmrs-esm-patient-vitals-app.js 3.37 kB

compressed-size-action

Copy link
Member

@ibacher ibacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@icrc-agomes Could you look into the failing tests. Likely we need to update a mock somewhere to ensure encounterTypes is always an empty array.

Copy link
Member

@ibacher ibacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @icrc-agomes! Couple of small things.

Comment on lines +76 to +78
encounterTypes: Array<{
encounterType: string;
}>;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
encounterTypes: Array<{
encounterType: string;
}>;
encounterTypes: Array<string>;

Comment on lines +50 to +54
showGraphByDefault: {
_type: Type.Boolean,
_description: 'Displayed graph by default',
_default: true,
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this should be added as part of this PR?

@icrc-agomes
Copy link
Contributor Author

@ibacher Hello Ian sorry for the late reply. There were some complications with this branch, all changes were made in this one #854

If you can check it I would appreciate it.

@gracepotma
Copy link
Contributor

@icrc-agomes can we close/cancel this PR if #854 is now the desired source of truth?

@icrc-agomes icrc-agomes deleted the feature/esm-generic-patient-widget-app-filter-by-encounter-types branch November 17, 2022 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants