(feat) Add ability to filter observations in the generic patient widget app by encounter type #854
Conversation
|
Requesting review by @vasharma05. FYI Vineet, @ibacher was reviewing #827 and believes this should be good to go, but great if you can review this one. FYI ICRC is blocked by this. |
| const { data } = useConfig(); | ||
| const { encounterTypes, data } = useConfig(); | ||
|
|
||
| const UrlEncounterTypes: string = encounterTypes.length ? `&encounter.type=${encounterTypes.toString()}` : ''; |
There was a problem hiding this comment.
| const UrlEncounterTypes: string = encounterTypes.length ? `&encounter.type=${encounterTypes.toString()}` : ''; | |
| const urlEncounterTypes: string = encounterTypes.length ? `&encounter.type=${encounterTypes.toString()}` : ''; |
There was a problem hiding this comment.
Seems better to name this variable encounterTypes.
There was a problem hiding this comment.
I used the suggested change 'urlEncounterTypes'
packages/esm-generic-patient-widgets-app/src/resources/useObs.ts
Outdated
Show resolved
Hide resolved
| _description: 'Displayed graph by default', | ||
| _default: true, | ||
| }, | ||
| encounterTypes: { |
There was a problem hiding this comment.
We should have a _description for this property as well.
There was a problem hiding this comment.
Parameter added
denniskigen
changed the title
There was a problem hiding this comment.
Looks Good, thanks @icrc-agomes 👍 , except for the merge conflicts, otherwise, we can merge it.
@hadijahkyampeire conflicts fixed :) Thanks. |
…et app by encounter type (openmrs#854) * Filter by encounter types implemented in observation endpoint on esm-generic-patient-widgets-app 2# * esm-generic-patient-widgets-app mock data for testing changed * Changes made in variables, tests and data structure Co-authored-by: Andre Gomes <[email protected]>
Requirements
Summary
In
esm-generic-patient-widgets-app, it was needed to implement the filter of observations endpoint by encounter type. Some changes were also made in the mock data for testing.Related Issue
This branch is a continuation of this pull request #827