Merge pull request #23 from openmrs/feat/support_prev_obs

(feat) Support for an encounter of previous obs values
openmrs · Dec 20, 2022 · 0441423 · 0441423
2 parents 8be1666 + 609609a
commit 0441423
Showing 1 changed file with 13 additions and 10 deletions.
diff --git a/projects/ngx-formentry/src/form-entry/helpers/historical-expression-helper-service.ts b/projects/ngx-formentry/src/form-entry/helpers/historical-expression-helper-service.ts
@@ -14,19 +14,22 @@ export class HistoricalHelperService {
 
   public evaluate(
     expr: string,
-    dataSources: any,
-    additionalScopevalues: any
-  ): any {
+    dataSources: Record<string, unknown>,
+    additionalScopeValues: Record<string, unknown> | null,
+  ) {
     const HD = new HistoricalEncounterDataService();
     HD.registerEncounters('prevEnc', dataSources['rawPrevEnc']);
-    const deps: any = {
-      HD: HD
-    };
+    if (dataSources.hasOwnProperty('rawPrevObs')) {
+      HD.registerEncounters('prevObs', dataSources['rawPrevObs']);
+    }
+
+    const deps = { HD };
 
-    if (additionalScopevalues) {
-      for (const o in additionalScopevalues) {
-        if (additionalScopevalues[o]) {
-          deps[o] = additionalScopevalues[o];
+    if (additionalScopeValues) {
+      for (const o in additionalScopeValues) {
+        const value = additionalScopeValues[o];
+        if (typeof value !== 'undefined' && value !== null) {
+          deps[o] = value;
         }
       }
     }