Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat) Support for an encounter of previous obs values #23

Merged
merged 1 commit into from
Dec 20, 2022

Conversation

ibacher
Copy link
Member

@ibacher ibacher commented Dec 19, 2022

Requirements

  • This PR has a title that briefly describes the work done, including the ticket number if there is a ticket.

Summary

This is a companion for the PR on patient chart to allow the form engine to use values from previous observations not necessarily on the form.

This behaviour is opt-in. A question can register its concept to get the most recent value by setting the questionOption useMostRecentValue to true or 'true'. Once that's done the most recent value for the concept associated with the question will be available in the historical data source under the pseudo-encounter "prevObs".

Screenshots

None.

Issue

None.

Other

None.

Copy link
Contributor

@hadijahkyampeire hadijahkyampeire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good to me!

@hadijahkyampeire hadijahkyampeire merged commit 0441423 into main Dec 20, 2022
@denniskigen denniskigen deleted the feat/support_prev_obs branch December 20, 2022 10:43
@ibacher ibacher restored the feat/support_prev_obs branch December 20, 2022 14:05
@ibacher
Copy link
Member Author

ibacher commented Dec 20, 2022

@hadijahkyampeire I tried to indicate that this code should not be merged as-is until testing is done. I'm going to revert the merge and re-open the PR. In future, please don't just merge code until it's ready.

ibacher added a commit that referenced this pull request Dec 20, 2022
This reverts commit 0441423, reversing
changes made to 8be1666.
@hadijahkyampeire
Copy link
Contributor

I am so sorry 🙏 @ibacher I think I miss that part I thought the other PR was the one we were waiting on, sorry about that, I saw you were on holiday and I thought you would not be available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants